Bug#910900: emacs-goodies-el: Upgrade to latest emacs-goodies-el fails in postinst: tsort complains about loops

[Sven Joachim <svenjoac@gmx.de>]

On 2018-10-12 19:20 -0700, Dima Kogan wrote:

> Package: emacs-goodies-el
> Version: 41.0
> Severity: normal
>
> Hi. I just upgraded my emacs bits, and the postinst now complains. I dug in a
> bit, and the complainy invocation ( and following errors) look like this:
>
>   root@fatty:/var/lib/dpkg/info# /usr/lib/emacsen-common/emacs-package-install --postinst emacs-goodies-el
>
>   Building autoloads for emacs-snapshot in /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el
>   ERROR: install script from emacs-goodies-el package failed
>
> The log file it mentioned (/tmp/elc_y5wceH.log) contains this:
>
>   emacs-snapshot -batch --no-site-file --multibyte --eval (setq
> load-path (cons "." load-path)) -l autoload --eval (setq
> generated-autoload-file (expand-file-name
> "emacs-goodies-loaddefs.el")) --eval (setq make-backup-files nil) -f
> batch-update-autoloads .
>   Warning (initialization): Ignoring obsolete arg --multibyte
>   all.el:0:0: error: file-missing: (Opening input file No such file or
> directory /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el/all.el)
>
> I'm not certain why it's still looking for all.el as this was removed.

Almost surely
/usr/share/emacs-snapshot/site-lisp/emacs-goodies-el/all.el is a
dangling symlink to /usr/share/emacs/site-lisp/emacs-goodies-el/all.el,
but I don't know why it has been left over.  The prerm script of
emacs-goodies-el should have called
/usr/lib/emacsen-common/packages/remove/emacs-goodies-el which removes
the whole /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el
directory.

Cheers,
       Sven