[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New from emacs-snapshot



Quoting Daniel Brockman <daniel@brockman.se>:

> > Thanks. I forgot about this one.
>
> I don't know if you want to add the other parameters as well.
> The emacs21 package has this,
...
> causes those options (prefix, sharedstatedir, libexecdir, and infodir)
> to be passed to `configure' (which will of course put them right into
> the Makefile), and you seem to already have dealt with the `manext'
> issue here:
...

That's right. I'll see if I can change that.

> >>  emacs_inst = (${MAKE} install \
> >>  		INSTALL_STRIP="-s" \
> >> +		debepkgdir=${1} \
> >>  		prefix=${1}/usr \
> >>  		sharedstatedir=${1}/var/lib \
> >>  		localstatedir=${1}/var \
> >
> > OK, I realized I had not taking too much care of this change.
> >
> > However, I think we could avoid patching Makefile.in and adding and
> > extra 'debepkgdir' parameter, that way:
> >
> > emacs_inst = (${MAKE} install \
> >                 INSTALL_STRIP="-s" \
> >                 prefix=${1}/usr \
> >                 sharedstatedir=${1}/var/lib \
> >                 localstatedir=${1}/var \
> >                 libexecdir=${1}/usr/lib \
> >                 infodir=${1}/usr/share/info/${info_emacsdir} \
> >                 mandir=${1}/usr/share/man \
> >                 manext=.1${bin_name} \
> >                 locallisppath=$(EMACS_COMMON)/$(subst
> :,:$(EMACS_COMMON)/,${local_lpath}))
> >
> > What do you think? (I haven't tested)
>
> Ah, yes, that looks great.  I didn't realize that locallisppath is
> only used in that one place in Makefile.in.
>
> I will try building with this change.

Good. Thanks.

> >> @@ -467,11 +469,13 @@
> >>  	# Emacs must be boostraped at least once in order to
> >>  	# generate .elc files
> >>  	CFLAGS="${CFLAGS}" ./configure ${emacs_confflags}
> >> +	${build_cmd} epaths-force
> >>  	${build_cmd} bootstrap
> >>  	${build_cmd} distclean
> >>
> >>  	# Build emacs
> >>  	CFLAGS="${CFLAGS}" ./configure ${emacs_confflags}
> >> +	${build_cmd} epaths-force
> >>  	${build_cmd}
> >>  	# save binary from deletion
> >>  	mv src/emacs src/x-emacs
> >> @@ -479,6 +483,7 @@
> >>
> >>  	# Build emacs-gtk
> >>  	CFLAGS="${CFLAGS}" ./configure ${emacs_gtk_confflags}
> >> +	${build_cmd} epaths-force
> >>  	time ${build_cmd}
> >>  	# save binary from deletion
> >>  	mv src/emacs src/gtk-emacs
> >> @@ -486,6 +491,7 @@
> >>
> >>  	# Build emacs-nox
> >>  	CFLAGS="${CFLAGS}" ./configure ${emacs_nox_confflags}
> >> +	${build_cmd} epaths-force
> >>  	time ${build_cmd}
> >>  	# save binary from deletion
> >>  	mv src/emacs src/nox-emacs
> >
> > Oh right, I understand now why it is necessary to run it out of
> > configure now.

BTW, I have a patch for configure.in which eliminates the need for
calling epaths-force after running configure. I'll submit it
to emacs-devel ASAP.

Cheers,

--
Jérôme Marant



Reply to: