RE: x-symbol package dangerous in multibyte environment
Steve Dunham wrote:
> Janusz S. Bie? wrote:
>>> * their system does not have the locale command
>> The LaTeX commands should be sufficient for a LaTeX documents.
Aren't we talking about an editor add-on here (also used for writing
LaTeX documents)? As I said, see the manual for details.
>>> * they don't read the warnings issued by X-Symbol (OK, it's a bit
>>> hidden with Emacs < 21.4).
>> GNU Emacs 21.2.1 (from a Debian package) gives no warning at all.
Wrong. As I've said, it's hidden with Emacs < 21.4 in buffer *Messages*:
Loading x-symbol-hooks...
Loading regexp-opt...done
Loading cl-seq...done
X-Symbol: cannot deduce default encoding, I'll assume `iso-8859-1'
Loading x-symbol-hooks...done
> We really should add a system like XEmacs' warning system to
> emacs.
Emacs-21.4 will have. People can already use it, see the beginning of
file lisp/x-symbol-emacs.el:
;; To make use of newer Emacs features with the current stable version of
;; Emacs, you can download individual files from the CVS repository of
;; <http://savannah.gnu.org/projects/emacs/>. E.g., I use Emacs-21.1.5
;; together with updates of the following files:
[...]
;; lisp/warnings.el,v 1.6(new): recommended
(condition-case nil (require 'warnings) (error))
> Once the issues are reported to me in detail, I'll address them in
> unstable, and then we can decide what to do with stable.
Steve, since the debian package is "half-beta", it's probably safer for
the moment to issue an error instead a warning with Emacs in this case
(see below for the patch), because the warning is not really visible in
Emacs. As I've said, I'll provide a real solution with v4.4.4.
- Christoph
diff -c /sapmnt/home1/d029492/a/emacs/emacs-21.1/lisp/x-symbol/x-symbol-hooks.el~ /sapmnt/home1/d029492/a/emacs/emacs-21.1/lisp/x-symbol/x-symbol-hooks.el
*** /sapmnt/home1/d029492/a/emacs/emacs-21.1/lisp/x-symbol/x-symbol-hooks.el~ Mon Nov 4 14:28:15 2002
--- /sapmnt/home1/d029492/a/emacs/emacs-21.1/lisp/x-symbol/x-symbol-hooks.el Mon Nov 4 14:28:16 2002
***************
*** 223,230 ****
(defvar x-symbol-default-coding
(cond (noninteractive 'iso-8859-1)
((x-symbol-coding-system-from-locale))
! (t
(warn "X-Symbol: cannot deduce default encoding, I'll assume `iso-8859-1'")
'iso-8859-1))
"Coding used for 8bit characters in buffers.
Also used for a 8bit file codings where `x-symbol-coding' has value nil.
--- 223,233 ----
(defvar x-symbol-default-coding
(cond (noninteractive 'iso-8859-1)
((x-symbol-coding-system-from-locale))
! ((or (featurep 'xemacs) (featurep 'warnings))
(warn "X-Symbol: cannot deduce default encoding, I'll assume `iso-8859-1'")
+ 'iso-8859-1)
+ (t
+ (error "X-Symbol: cannot deduce default encoding, use something like (setq x-symbol-default-coding 'iso-8859-1)")
'iso-8859-1))
"Coding used for 8bit characters in buffers.
Also used for a 8bit file codings where `x-symbol-coding' has value nil.
Reply to: