[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1093432: marked as done (fwupd: install_dell_bios_exe.py does not install updates (Expected a Fwupd.DeviceFlags, but got int))

Your message dated Tue, 18 Mar 2025 23:38:55 +0000
with message-id <E1tugWN-005hn8-17@fasolo.debian.org>
and subject line Bug#1093432: fixed in fwupd 2.0.6-5
has caused the Debian Bug report #1093432,
regarding fwupd: install_dell_bios_exe.py does not install updates (Expected a Fwupd.DeviceFlags, but got int)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1093432: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093432
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fwupd
Version: 2.0.3-3
Severity: important
Tags: patch upstream
X-Debbugs-Cc: adrien@adorsaz.ch

Dear Maintainer,

I needed to update the TPM firmware of my DELL Latitude 5580 laptop and
I found
a firmware update on the DELL support site. I downloaded the ".exe"
update and
tried to install it with the install_dell_bios_exe.py tool provided by
the
fwupd package on Debian testing.

The script seems to run fine but it prints an error in the middle of
its output
(I outlined the error line with stars):

> root@bulbizarre:/usr/share/fwupd# ./install_dell_bios_exe.py
~/DellTpm2.0_Fw1.3.2.8_V3_64.exe
> org.freedesktop.fwupd property OnlyTrusted, current value is True
> setting configuration key OnlyTrusted to false
> org.freedesktop.fwupd property OnlyTrusted, current value is False
> *** Expected a Fwupd.DeviceFlags, but got int ***
> org.freedesktop.fwupd property OnlyTrusted, current value is False
> setting configuration key OnlyTrusted to true
> org.freedesktop.fwupd property OnlyTrusted, current value is True
> An update requires a reboot to complete
> Restart now? (Y/N) n
> Reboot your machine manually to finish the update.

First I did not notice this error and I was surprised on reboot the
fwupd
updater said there was no upgrade to install.

The error is about an integer received instead of a DeviceFlags, so
I've
inspected the script and I noticed a missusage of the
[has_flag](https://fwupd.github.io/libfwupd/method.Device.has_flag.html
)
method which expects an FwupdDeviceFlags as argument (in the
find_uefi_device
method).

I've updated the script with this patch (I've choosed the flags
according to
the comments):

$ diff install_dell_bios_exe.py install_dell_bios_exe.py.fixed
71c71
<         if not item.has_flag(1 << 0):
---
>         if not item.has_flag(Fwupd.DeviceFlags.INTERNAL):
74c74
<         if not item.has_flag(1 << 8):
---
>         if not item.has_flag(Fwupd.DeviceFlags.NEEDS_REBOOT):

With this patch, the output of the script was more complete and
contained
information about a file found and added to install on the next
upgrade.

On the next reboot fwupd has successfully found the upgrade and
installed it
correctly on my computer.

Best regards,

Adrien

PS: I've just checked on upstream git repository and it seems their
python
script is same code than currently installed on my system:

> adrien-local@bulbizarre:~/code/fwupd$ git remote -v
> origin        https://github.com/fwupd/fwupd.git ;(fetch)
> origin        https://github.com/fwupd/fwupd.git ;(push)
> adrien-local@bulbizarre:~/code/fwupd$ git status
> Sur la branche main
> Votre branche est à jour avec 'origin/main'.
>
> rien à valider, la copie de travail est propre
> adrien-local@bulbizarre:~/code/fwupd$ git log | head -n 1
> commit b499847076aaadcdbf6ae997e4e082146d1b44af
> adrien-local@bulbizarre:~/code/fwupd$ diff
/usr/share/fwupd/install_dell_bios_exe.py
contrib/firmware_packager/install_dell_bios_exe.py
> adrien-local@bulbizarre:~/code/fwupd$


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=fr_CH.UTF-8, LC_CTYPE=fr_CH.UTF-8 (charmap=UTF-8),
LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fwupd depends on:
ii  libarchive13t64             3.7.4-1.1
ii  libblkid1                   2.40.2-13
ii  libc6                       2.40-5
ii  libcbor0.10                 0.10.2-2
ii  libcurl3t64-gnutls          8.11.1-1
ii  libdrm-amdgpu1              2.4.123-1
ii  libdrm2                     2.4.123-1
ii  libflashrom1                1.4.0-3
ii  libfwupd3                   2.0.3-3
ii  libglib2.0-0t64             2.82.4-2
ii  libgnutls30t64              3.8.8-2
ii  libjcat1                    0.2.0-2+b3
ii  libjson-glib-1.0-0          1.10.6+ds-1
ii  liblzma5                    5.6.3-1+b1
ii  libmbim-glib4               1.30.0-1+b2
ii  libmbim-proxy               1.30.0-1+b2
ii  libmm-glib0                 1.22.0-3+b2
ii  libpolkit-gobject-1-0       126-1
ii  libprotobuf-c1              1.4.1-1+b3
ii  libqmi-glib5                1.34.0-2+b2
ii  libqmi-proxy                1.34.0-2+b2
ii  libsqlite3-0                3.46.1-1
ii  libsystemd0                 257.2-1
ii  libtss2-esys-3.0.2-0t64     4.1.3-1.2
ii  libusb-1.0-0                2:1.0.27-1+b1
ii  libxmlb2                    0.3.21-1
ii  shared-mime-info            2.4-5+b1
ii  systemd [systemd-sysusers]  257.2-1
ii  zlib1g                      1:1.3.dfsg+really1.3.1-1+b1

Versions of packages fwupd recommends:
ii  bolt                               0.9.8-1
ii  dbus [default-dbus-system-bus]     1.16.0-1
ii  fwupd-amd64-signed [fwupd-signed]  1:1.7+1
ii  jq                                 1.7.1-3+b1
ii  python3                            3.12.8-1
pn  secureboot-db                      <none>
ii  udisks2                            2.10.1-11

Versions of packages fwupd suggests:
ii  gir1.2-fwupd-2.0  2.0.3-3

-- Configuration Files:
/etc/fwupd/fwupd.conf [Errno 13] Permission non accordée:
'/etc/fwupd/fwupd.conf'

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: fwupd
Source-Version: 2.0.6-5
Done: Mario Limonciello <superm1@gmail.com>

We believe that the bug you reported is fixed in the latest version of
fwupd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1093432@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mario Limonciello <superm1@gmail.com> (supplier of updated fwupd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Mar 2025 17:07:45 -0500
Source: fwupd
Built-For-Profiles: noudeb
Architecture: source
Version: 2.0.6-5
Distribution: unstable
Urgency: medium
Maintainer: Debian EFI <debian-efi@lists.debian.org>
Changed-By: Mario Limonciello <superm1@gmail.com>
Closes: 980570 1005417 1064877 1093432 1099791 1100757
Changes:
 fwupd (2.0.6-5) unstable; urgency=medium
 .
   [ Michael Biebl ]
   * Remove obsolete conffiles on upgrade (Closes: #1064877, #1100757)
   * Bump versions of existing rm_conffile entries (Closes: #980570, #1005417)
 .
   [ Mario Limonciello ]
   * Backport a patch to fix install_dell_bios_exe.py (Closes: #1093432)
   * Backport a patch to fix a critical warning (Closes: #1099791)
   * Backport a patch to fix compilation against newer Pango versions
Checksums-Sha1:
 7278c6b92abd8e30a7442f6666e3b8c6cea34ecb 3423 fwupd_2.0.6-5.dsc
 29235beb25b3a43a81dc26931400ec6356eb7b47 30000 fwupd_2.0.6-5.debian.tar.xz
 c76a438600f126a77e804f00375c0600dfc2388c 21538 fwupd_2.0.6-5_source.buildinfo
Checksums-Sha256:
 55c26d244594bb4d3d2e52f3f1c992390bc27f6cf0d172fe746d5503810273f6 3423 fwupd_2.0.6-5.dsc
 57928263e0ed3c66423cc39bef0309f94292beeaeb584b869c84413de64798fb 30000 fwupd_2.0.6-5.debian.tar.xz
 6701b2bda3955edaff419cb21e98cc47d872713f8097d5f8a2b663da986b63fd 21538 fwupd_2.0.6-5_source.buildinfo
Files:
 c6490afa422cd814f55f452b4e5b8a4e 3423 admin optional fwupd_2.0.6-5.dsc
 728191291b67b71ce43126f055ab181e 30000 admin optional fwupd_2.0.6-5.debian.tar.xz
 14133f6a15e323b6ed8b32340d0b6cfa 21538 admin optional fwupd_2.0.6-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEECwtuSU6dXvs5GA2aLRkspiR3AnYFAmfZ7uoSHHN1cGVybTFA
Z21haWwuY29tAAoJEC0ZLKYkdwJ2Gj8QAMerheNcmUB6ynYQBAxzYUTuoCp8xQS5
TOTLYQ4hN3QyV6oiF7iapj4nzWpOYZYi3nmz/tTCWY6rmC0grO6KPi7Bfun4JQl0
ci9hE5bRFTkdciDeXZZR7Qk/udMUM9srf3ZXuHUcfuyvfKLdnzPilS0eSvcHuqVu
DgyUF6ogdGvoFDbj1JCI+afUPfISbouheluqZRa+N+/yGi2DyuFKnJWDN2H0Io1d
AUecjyUAYciAOjkglnxWURkeYepHj3/PMVmrqFmgE2o2aYUuM0veNLFCkROL6GtX
87pXWpjN++16FqliPPEaOWZToaFNYARAAcIixwnLvwK8ZDtbLTk/q0sGWtGl3OiM
44TvrtWXjhw5BqpOak4FXLTJFhWdx1uqCw3ETxR7nCV29us7W+K03hoPjio8G61V
UUOCR54ZuuOUw9aCqsMYcfxvzTCniE8lTROgHVQEaLMUx2czG8odcjbSgmp2xCjp
7m6srcxTQAKS6oQcKEwuPwZAU5yBEU7CS5/M0kFp8lOOHWov3h7wjuep8BZ/dpzb
FLOJn9wYdXthh1gMsvxg+Sf0f1a5SXGlk/0dYcQWshcWGCTXt3KH9K6Y8mrJgXs2
DnAj2zzTcZj3w5+r6u6sVaMGikEZAon2rEpgLHr2PgjQlO3bc5yPfmbSG5XH471M
LY/HTzBcTQ8e
=laFz
-----END PGP SIGNATURE-----

Attachment: pgpq6fzWc394R.pgp
Description: PGP signature


--- End Message ---
Reply to: