Bug#1069410: NMU fix actually removed files from the package
On Tue, Feb 25, 2025 at 11:26:58AM +0100, Yves-Alexis Perez wrote:
> On Tue, Feb 25, 2025 at 11:13:40AM +0100, Yves-Alexis Perez wrote:
> > On Tue, Feb 25, 2025 at 10:03:37AM +0000, Luca Boccassi wrote:
> > > On Tue, 25 Feb 2025 at 09:57, Yves-Alexis Perez <corsac@debian.org> wrote:
> > > Would you be able to provide a patch that fixes them?
> >
> > Unfortunately no, but I only discovered the bug today while trying to
> > use KeyTool.efi and not finding it. Is upstream aware of the issue?
>
> So I did a quick test by reverting the changes to the Makefile disabling
> the EFI binaries build and it *seems* to actually work just fine, at
> least here on my box.
>
> It's really a smoke test but I'm not sure how well the Ubuntu changes
> have been checked. It seems to me they did a lot of work to fix the
> FTBFS but the "stop building EFI binaries" might be unrelated.
Here's the (trivial) patch I used.
--
Yves-Alexis Perez
From: Yves-Alexis Perez <corsac@debian.org>
Date: Tue, 25 Feb 2025 11:24:03 +0100
X-Dgit-Generated: 1.9.2-3.2 0e4292b287dfbfa1afd90fdff2e863a6ef979ccb
Subject: revert not building files
---
diff --git a/Makefile b/Makefile
index 7a37b72..fc061a6 100644
--- a/Makefile
+++ b/Makefile
@@ -30,13 +30,15 @@ include Make.rules
EFISIGNED = $(patsubst %.efi,%-signed.efi,$(EFIFILES))
-all: $(BINARIES) $(MANPAGES) noPK.auth $(KEYAUTH) \
+all: $(EFISIGNED) $(BINARIES) $(MANPAGES) noPK.auth $(KEYAUTH) \
$(KEYUPDATEAUTH) $(KEYBLACKLISTAUTH) $(KEYHASHBLACKLISTAUTH)
install: all
$(INSTALL) -m 755 -d $(MANDIR)
$(INSTALL) -m 644 $(MANPAGES) $(MANDIR)
+ $(INSTALL) -m 755 -d $(EFIDIR)
+ $(INSTALL) -m 755 $(EFIFILES) $(EFIDIR)
$(INSTALL) -m 755 -d $(BINDIR)
$(INSTALL) -m 755 $(BINARIES) $(BINDIR)
$(INSTALL) -m 755 mkusb.sh $(BINDIR)/efitool-mkusb
Reply to: