[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1070790: marked as done (fwupd: flaky autopkgtest on arm64: fwupd/fwupdmgr-p2p.test: The connection is closed)

Your message dated Fri, 06 Dec 2024 16:19:59 +0000
with message-id <E1tJb3f-0044Cq-4x@fasolo.debian.org>
and subject line Bug#1070790: fixed in fwupd 2.0.3-1
has caused the Debian Bug report #1070790,
regarding fwupd: flaky autopkgtest on arm64: fwupd/fwupdmgr-p2p.test: The connection is closed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1070790: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1070790
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: fwupd
Version: 1.9.19-1
Severity: important
User: debian-ci@lists.debian.org
Usertags: flaky
X-Debbugs-Cc: debian-ci@lists.debian.org
Control: affects -1 + src:glib2.0
Control: found -1 1.9.16-1

fwupd appears to have a "flaky" autopkgtest: that is, an autopkgtest
that usually passes, but is not reliable.

This means that when packages that are depended on by the test suite, such
as the glib2.0 security fix currently in unstable, are trying to migrate
to testing, the test will randomly pass or fail, causing those packages
to be detected as having caused a regression when in fact they have not.

For example see
https://ci.debian.net/packages/f/fwupd/testing/arm64/46456704/
(while testing a new glib2.0),
https://ci.debian.net/packages/f/fwupd/testing/arm64/46242873/
(while testing a new sqlite) and
https://ci.debian.net/packages/f/fwupd/testing/s390x/46251882/
(while testing a new fwupd).

I suspect this is a race condition in the test, rather than a result of
a change immediately before one of those runs. This appears to happen
rarely on arm64, very rarely on s390x, and in practice never on amd64 -
which again makes me think that timing is involved.

"The connection is closed" is the error message used by GLib's GDBus when
a D-Bus connection is closed with D-Bus method calls still "in-flight",
or when the D-Bus connection is flushed or closed or an attempt is made
to send a message after it is already closed.

Perhaps this test closes a D-Bus connection during teardown, and there is
a race condition in which it might or might not have finished doing other
things on that connection before that point?

If this test or this feature cannot be made fully reliable, one option
is to skip it in debian/tests/ci, and re-run it in a separate
autopkgtest script that is marked as "Restrictions: flaky". A few GNOME
packages use the convention that flaky tests are marked like this:

    @unittest.skipIf('DEB_ALLOW_FLAKY_TESTS' not in os.environ, 'https://bugs.debian.org/123456')
    def test_something_flaky(...):
        ...

(or the equivalent in other languages) so that they are normally skipped,
but we can force them to be run (to assess whether they are still a
problem!) by using "export DEB_ALLOW_FLAKY_TESTS=1".

    smcv

--- End Message ---
--- Begin Message --- 
Source: fwupd
Source-Version: 2.0.3-1
Done: Mario Limonciello <superm1@gmail.com>

We believe that the bug you reported is fixed in the latest version of
fwupd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1070790@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mario Limonciello <superm1@gmail.com> (supplier of updated fwupd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 06 Dec 2024 09:58:30 -0600
Source: fwupd
Built-For-Profiles: noudeb
Architecture: source
Version: 2.0.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian EFI <debian-efi@lists.debian.org>
Changed-By: Mario Limonciello <superm1@gmail.com>
Closes: 1070790 1079481
Changes:
 fwupd (2.0.3-1) unstable; urgency=medium
 .
   [ Mario Limonciello ]
   * New upstream version (2.0.3)
   * Mark fwupdmgr-p2p tests as flaky (Closes: #1070790)
 .
   [ Simon McVittie ]
   * Add trivial compile/link/run test for libfwupdplugin-dev
   * d/control, d/control.in: tests depend on a system bus, not dbus-x11
     (Closes: #1079481)
   * d/control, d/control.in: Recommend a non-specific D-Bus system bus
Checksums-Sha1:
 891d3c3ab556b71afc9072a465ab8af79841eaf6 3434 fwupd_2.0.3-1.dsc
 24342ace956a6cbe59438b6376554588359d5b18 6520967 fwupd_2.0.3.orig.tar.gz
 9868446916dc5fc9c26c8b14e34cba3b19ee1f28 27604 fwupd_2.0.3-1.debian.tar.xz
 bfebf72d4437833980ff05dc75a22f3279ae3818 21668 fwupd_2.0.3-1_source.buildinfo
Checksums-Sha256:
 b6ee5b34a6aa9dfc60149551d46f3933b8643465551169e96de77b4803c75c93 3434 fwupd_2.0.3-1.dsc
 c846b77120d134b04f7adc5e7a15aba282b815e3919154c05178e9c1be10399b 6520967 fwupd_2.0.3.orig.tar.gz
 8a11b91150dd79bbdeb8e5f8c9fea531cd3f17cd1e5598ff208f978ec818bc54 27604 fwupd_2.0.3-1.debian.tar.xz
 7258c6a77a19b4d4ef3e86bb97d046927e8a8c1f791278b56cb8f0b3ce6fd7e6 21668 fwupd_2.0.3-1_source.buildinfo
Files:
 4a9b980c685938a29745b4fc5804c799 3434 admin optional fwupd_2.0.3-1.dsc
 3c9196a05d3015ccc169609b941f0d28 6520967 admin optional fwupd_2.0.3.orig.tar.gz
 e120e85932fa6d1411ffb23aacd3a9c2 27604 admin optional fwupd_2.0.3-1.debian.tar.xz
 5373706c16f1ab846046b1350ffad055 21668 admin optional fwupd_2.0.3-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEECwtuSU6dXvs5GA2aLRkspiR3AnYFAmdTH1QSHHN1cGVybTFA
Z21haWwuY29tAAoJEC0ZLKYkdwJ2kYUQAJTwCwsrDCRZeRd11R+z1MfhLOKZ/tyt
ZITnmQAqoQWAIHQ+nBckXhRAYQSyvalWdjlpjoPwCLrs8rwhGIegKykv7DkSX7sW
O6cTSNONnch4vI7UeVHvXtkNFwPWC74btBMlRq7MogHL/tTyjdKcQ41XosZ5IP4o
GWFYQQmXBWlj8KjNmXf/fgt7x+mO5hg33Wopul2DQZ/IYs5F86myy+bKQH2+Ibjo
Mi13PE5t+Amvd1z0xpZu7/Kxw3LVtHdNHZYJKwb7vDVWDjiKXu7HyImHYWyFg9ey
fdflhj2kSCNsfm2wQUU17IfY4ZyC3fqh81SQNJXHoenOUVxdtOplYChexqz9NIm/
8LGrZdTosByehXG35hqQb1VWXHbk9r9yDcXElD3OGz/RlRFcFcHIGvsiAItFyoab
f35Jew54IJ4JkQOdAE5vEgJqGrX92aE1qgBKcrNpJElewRMNdQmRVKQ1vnlYj2AE
1ksntYY3qt/4GGqvo3e97Arp4qHI5DnQjxEb5mgBEQyGHYsxlUvxq5A47N5Vil7H
zdTcWePjHb0bm7GkBWqzP8Ce5s6OQWjzo38hfwVKNxNerVNDQqSQ/qYnLXaAr9bg
V2ISGIi9y7SsEacoPk+mNaA1OadgSfZMh6diqmP/ZihEiebgBsRwk59/XE8jGsQE
HmTJv72y8w/W
=ugPi
-----END PGP SIGNATURE-----

Attachment: pgpw6b9Up5qCA.pgp
Description: PGP signature


--- End Message ---
Reply to: