[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1041752: fwupd: ships empty directory /lib/systemd/system-preset



Source: fwupd
Version: 1.9.3-1
Severity: important
Tags: patch

fwupd ships an empty directory /lib/systemd/system-preset. This
directory is prone to loss since we implemented the /usr-merge using
aliasing. Another package may install a file into
/usr/lib/systemd/system-preset and when that package is removed, this
empty directory is deleted as well.

fwupd used to install a preset file there, but no longer does. This
directory is not crucial to fwupd and can be deleted as well. Once
deleted, it can no longer be lost. I'm attaching a patch for your
convenience.

Helmut
diff -Nru fwupd-1.9.3/debian/changelog fwupd-1.9.3/debian/changelog
--- fwupd-1.9.3/debian/changelog	2023-07-11 18:15:06.000000000 +0200
+++ fwupd-1.9.3/debian/changelog	2023-07-23 06:45:46.000000000 +0200
@@ -1,3 +1,10 @@
+fwupd (1.9.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Avoid shipping empty directory /lib/systemd/system-preset. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 23 Jul 2023 06:45:46 +0200
+
 fwupd (1.9.3-1) unstable; urgency=medium
 
   * New upstream version (1.9.3)
diff -Nru fwupd-1.9.3/debian/rules fwupd-1.9.3/debian/rules
--- fwupd-1.9.3/debian/rules	2023-07-11 18:15:06.000000000 +0200
+++ fwupd-1.9.3/debian/rules	2023-07-23 06:45:44.000000000 +0200
@@ -78,6 +78,8 @@
 
 	#enable fwupd-refresh.service by default (we have a dedicated user)
 	rm -f debian/fwupd/lib/systemd/system-preset/fwupd-refresh.preset
+	# avoid shipping an empty directory
+	find debian/fwupd/lib/systemd -type d -empty -delete
 
 override_dh_strip_nondeterminism:
 	dh_strip_nondeterminism -Xfirmware-example.xml.gz

Reply to: