Bug#955258: libjcat-dev: -dev package missing some required dependencies
Package: libjcat-dev
Version: 0.1.0-1
Severity: important
Tags: patch
I tried adding some basic autopkgtests to libjcat. One useful thing to do
in an autopkgtest for a library is to compile a "hello world" program
against the library. This often reveals missing -dev dependencies,
and in the case of libjcat that's exactly what happened.
Please see attached.
smcv
>From 33144e96f92834fc96b23f5a7fd40ba70859dd7b Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Sat, 28 Mar 2020 17:15:31 +0000
Subject: [PATCH 4/9] libjcat-dev: Add missing -dev dependencies
Without these, building a trivial program against libjcat fails with
errors like:
+ pkg-config --cflags --libs jcat
Package gio-2.0 was not found in the pkg-config search path.
Signed-off-by: Simon McVittie <smcv@debian.org>
---
debian/control | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 7790953..fdecfbf 100644
--- a/debian/control
+++ b/debian/control
@@ -41,7 +41,13 @@ Section: libdevel
Architecture: any
Multi-Arch: same
Pre-Depends: ${misc:Pre-Depends}
-Depends: ${misc:Depends}, ${shlibs:Depends}, gir1.2-jcat-1.0 (= ${binary:Version})
+Depends: ${misc:Depends},
+ ${shlibs:Depends},
+ gir1.2-jcat-1.0 (= ${binary:Version}),
+ gnutls-dev,
+ libglib2.0-dev,
+ libgpgme11-dev,
+ libjson-glib-dev,
Description: development files for libjcat
This package provides development libraries for libjcat.
.
--
2.26.0
>From 35d9f740892e63c76cf77246643ca246b86b1ce8 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Sat, 28 Mar 2020 19:40:15 +0000
Subject: [PATCH 5/9] libjcat-dev: Add missing dependency on a matching
libjcat1
Signed-off-by: Simon McVittie <smcv@debian.org>
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index fdecfbf..9dff12e 100644
--- a/debian/control
+++ b/debian/control
@@ -47,6 +47,7 @@ Depends: ${misc:Depends},
gnutls-dev,
libglib2.0-dev,
libgpgme11-dev,
+ libjcat1 (= ${binary:Version}),
libjson-glib-dev,
Description: development files for libjcat
This package provides development libraries for libjcat.
--
2.26.0
>From b9fe0a03b92b51db3cbc9340817147bdd4b48a99 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Sat, 28 Mar 2020 19:41:09 +0000
Subject: [PATCH 6/9] d/control: Enable gir debhelper sequence
Otherwise ${gir:Depends} won't be generated.
Signed-off-by: Simon McVittie <smcv@debian.org>
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index 9dff12e..c187197 100644
--- a/debian/control
+++ b/debian/control
@@ -5,6 +5,7 @@ Maintainer: Debian EFI team <debian-efi@lists.debian.org>
Uploaders: Steve McIntyre <93sam@debian.org>,
Mario Limonciello <mario.limonciello@dell.com>
Build-Depends: debhelper-compat (=12),
+ dh-sequence-gir,
help2man,
gnutls-bin,
gnutls-dev,
--
2.26.0
Reply to: