[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845815: marked as done (efibootmgr FTCBFS: uses build architecture pkg-config)

Your message dated Sat, 7 Dec 2019 07:50:04 +0100
with message-id <20191207065003.GA25723@alf.mars>
and subject line Re: Bug#845815: efibootmgr FTCBFS: uses build architecture pkg-config
has caused the Debian Bug report #845815,
regarding efibootmgr FTCBFS: uses build architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
845815: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845815
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: efibootmgr
Version: 14-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

efibootmgr fails to cross build from source, because it uses the build
architecture pkg-config and thus fails finding efivar.h. The cause is
that debhelper simply passes cross compilers for CC and CXX, but the
build system of efibootmgr expects setting CROSS_COMPILE instead. Thus
the attached patch opts out of dh_auto_build and explicitly sets up
CROSS_COMPILE. Please consider applying it.

Helmut

diff --minimal -Nru efibootmgr-14/debian/changelog efibootmgr-14/debian/changelog
--- efibootmgr-14/debian/changelog	2016-09-29 17:39:14.000000000 +0200
+++ efibootmgr-14/debian/changelog	2016-11-26 22:10:56.000000000 +0100
@@ -1,3 +1,10 @@
+efibootmgr (14-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Pass CROSS_COMPILE instead of overriding CC (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sat, 26 Nov 2016 22:10:56 +0100
+
 efibootmgr (14-1) unstable; urgency=medium
 
   * New upstream version (14)
diff --minimal -Nru efibootmgr-14/debian/rules efibootmgr-14/debian/rules
--- efibootmgr-14/debian/rules	2016-09-29 17:39:14.000000000 +0200
+++ efibootmgr-14/debian/rules	2016-11-26 22:10:56.000000000 +0100
@@ -2,12 +2,17 @@
 # rules file for the efibootmgr package, requires debhelper / dh
 # copyright 2012 by Bdale Garbee, GPLv2 or later
 
+include /usr/share/dpkg/architecture.mk
+
 export DH_VERBOSE=1
 export DH_OPTIONS=-v
 
 %:
 	dh $@
 
+override_dh_auto_build:
+	CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)- $(MAKE)
+
 # upstream build installs into /usr/sbin ignoring target directory;
 # since the install step is not actually needed just skip it
 override_dh_auto_install:

--- End Message ---
--- Begin Message --- 
On Sat, Nov 26, 2016 at 10:18:03PM +0100, Helmut Grohne wrote:
> efibootmgr fails to cross build from source, because it uses the build
> architecture pkg-config and thus fails finding efivar.h. The cause is
> that debhelper simply passes cross compilers for CC and CXX, but the
> build system of efibootmgr expects setting CROSS_COMPILE instead. Thus
> the attached patch opts out of dh_auto_build and explicitly sets up
> CROSS_COMPILE. Please consider applying it.

debhelper now passes PKG_CONFIG and efibootmgr picks that up. Therefore
cross builds succeed now:

http://crossqa.debian.net/src/efibootmgr

Closing the bug.

Helmut

--- End Message ---
Reply to: