[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#943465: fwupd is wrongly marked Multi-Arch: foreign




> -----Original Message-----
> From: Helmut Grohne <helmut@subdivi.de>
> Sent: Friday, October 25, 2019 9:30 AM
> To: Limonciello, Mario
> Cc: 943465@bugs.debian.org
> Subject: Re: Bug#943465: fwupd is wrongly marked Multi-Arch: foreign
> 
> 
> [EXTERNAL EMAIL]
> 
> On Fri, Oct 25, 2019 at 02:08:34PM +0000, Mario.Limonciello@dell.com wrote:
> > I took a stab at how this should work here (not yet merged):
> >
> https://github.com/fwupd/fwupd/commit/809eb181f57dc5158b5d37d2855a0a48
> eafc3565
> >
> > Can you please review that and make sure you agree it's done correctly?
> 
> I think this should technically work, but it seems unnecessarily
> complex.

Thanks for reviewing it.

> 
> You split the various firmware packages into
> fwupd-$(DEB_HOST_ARCH)-unsigned. Why did you do that? Why not have one
> real fwupd-unsigned package? Clearly you intend them to be
> coinstallable, which is why you marked them M-A:same. Note that M-A:same
> doesn't make sense, when you only list one specific architecture in the
> Architecture field. Can you maybe do the following?
> 
> d/control:
> Package: fwupd-unsigned
> Architecture: amd64 i386 ...
> Multi-Arch: same
> no Provides:
> 
> I also think that Built-Using must refer to real packages, which is not
> presently the case. My suggestion would ensure that.
> 

I made some modifications and think I captured your suggestion here
https://github.com/fwupd/fwupd/commit/3508aecefdbd81924314834ac9e14bcd71aa253f

Can you make sure that looks good now?


Reply to: