[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#853237: ENOSPC errors should be more helpful

On 07/08/2018 21:41, Alexis Murzeau wrote:
> Hi,
> On Mon, 30 Jan 2017 18:42:58 +0000 Steve McIntyre <steve@einval.com> wrote:
>> Package: efibootmgr
>> Version: 0.11.0-3
>> Severity: important
>> Tags: upstream
>> Hi,
>> I've seen a growing number of people reporting efibootmgr failing with
>> ENOSPC when trying to add new boot entries, e.g. on grub-efi
>> upgrades. It's a worrying trend, and users are ending up with
>> unbootable systems (hence the severity).
>> #852513 is a great example. Norbert has done an excellent job of
>> investigating the problem (thankfully) and in his case this seems to
>> be a problem with the pstore filling up. Maybe this is the cause of a
>> number of these problems (e.g. #756253).
>> With ENOSPC error, at the very least, we should:
>>  * warn users that their system may fail to boot
>>  * give some ideas on what might be the cause
>>  * suggest ways to investigate and/or fix the problem
>> We could even check for files in /sys/fs/pstore and complain if
>> they're taking up too much space, maybe?
> Other potential solutions:
>  * Propose or silently remove dumps (generated via pstore), or maybe
> leave only one dump
>  * Avoid recreating entries if they are not changed or create the new
> entries before removing the old ones (so if it fails, old ones are still
> there)
> The dumps in pstore are kernel oops dumps.
> I'm not sure if these are possible to implement or if they are good ones.

Or maybe refuse to do anything if there is no more than a minimum
required free space left on device.
But that minimum required free space need to be determined.

Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: