[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883489: fwupdate FTCBFS: multiple reasons

Thank you for the diff.  It looks fine to me and something we can apply for the next upload.
Would you please also submit a PR to upstream for the upstream applicable parts (0003-cross.patch).

> -----Original Message-----
> From: Helmut Grohne [mailto:helmut@subdivi.de]
> Sent: Monday, December 4, 2017 10:53 AM
> To: Debian Bug Tracking System <submit@bugs.debian.org>
> Subject: Bug#883489: fwupdate FTCBFS: multiple reasons
> Source: fwupdate
> Version: 9-3
> Tags: patch
> User: helmutg@debian.org
> Usertags: rebootstrap
> fwupdate fails to cross build from source for a number of reasons:
>  1. It uses the build architecture objcopy, because dh_auto_build passes
>     neither OBJCOPY nor CROSS_COMPILE. While the CROSS_COMPILE variable
>     is somewhat general, it's not as widely adopted. dh_auto_build
>     explicitly sets tools such as CC or PKG_CONFIG. Explicitly passing
>     CROSS_COMPILE makes this part work.
>  2. The upstream build system hard codes the use of the build
>     architecture pkg-config. While it considers CROSS_COMPILE for other
>     tools (including CC, LD and OBJCOPY) it fails to do so for
>     pkg-config. I think this is an upstream bug and it should allow
>     substituting pkg-config just like the other tools.
>  3. It derives FWUP in efi/Makefile from ARCH and ARCH from CC.
>     Unfortunately, dh_auto_install doesn't pass CC (only dh_auto_build
>     does). Thus FWUP differs between build and install and thus tries to
>     build more stuff. An easy way to solve this is to simply pass
>     CROSS_COMPILE to make install as well.
> After fixing all of the above, fwupdate cross builds successfully.
> Please consider applying the attached patch.
> Helmut

Reply to: