[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Reproducible builds for fwupdate

Gah, missed this in my inbox - sorry!

On Wed, Apr 06, 2016 at 10:48:54AM -0500, Mario_Limonciello@Dell.com wrote:
>I was really hoping to make fwupdate's build fully reproducible in
>the last upload, but it seems it still failed on the PO file:
>I had tried to fix this with
 but that seems to have still not done the trick.
>To me this looks like it might be a matter of a TZ variable from the
>buildd leaking into the environment.  Could I get another set of eyes
>whether this fix should do the trick to resolve in the next upload?
>diff --git a/debian/rules b/debian/rules
>index 6181785..1cd009f 100755
>--- a/debian/rules
>+++ b/debian/rules
>@@ -3,7 +3,7 @@
>DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
>EFIDIR ?= $(shell dpkg-vendor --query vendor | awk '{ print tolower($$0) }')
>-PODATE := $(shell dpkg-parsechangelog --show-field Date | xargs -0 date "+%Y-%m-%d %H:%M%z" --date)
>+PODATE := $(shell dpkg-parsechangelog --show-field Date | xargs -0 date --utc "+%Y-%m-%d %H:%M%z" --date)

I'd just use "-u" rather than "--utc" normally, but this looks like it
should help yes!

>ifeq (yes,$(shell dpkg-vendor --derives-from Ubuntu && echo yes))
>Mario Limonciello
>Dell | CPG Software Engineering
Steve McIntyre, Cambridge, UK.                                steve@einval.com
  Armed with "Valor": "Centurion" represents quality of Discipline,
  Honor, Integrity and Loyalty. Now you don't have to be a Caesar to
  concord the digital world while feeling safe and proud.

Reply to: