[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1040296: debian-edu-artwork: leaves diversion dating back to squeeze: /usr/share/desktop-base/grub_background.sh



Package: debian-edu-artwork
Version: 2.12.2-2
Severity: important
Tags: patch
User: debian-qa@lists.debian.org
Usertags: piuparts
Control: found -1 2.11.1-1

Hi,

during a test with piuparts I noticed your package fails to remove some
diversions after upgrading from squeeze and removing the package
afterwards.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

>From the attached log (scroll to the bottom...):

6m13.3s ERROR: FAIL: Installed diversions (dpkg-divert) not removed by purge:
  diversion of /usr/share/desktop-base/grub_background.sh to /usr/share/desktop-base/grub_background.sh.orig by debian-edu-artwork

The diversion originates in squeeze and is left over if
debian-edu-artwork was installed in squeeze and has been upgraded
release by release to bookworm.

The cleanup code existed in the prerm script before 2.11.1-1, but
instead of dropping the prerm script, the cleanup code should have been
moved to the postinst script. Doing that now.


cheers,

Andreas
>From 0bb552d5fb077e69978f8555805b3abf53b6ea4c Mon Sep 17 00:00:00 2001
From: Andreas Beckmann <anbe@debian.org>
Date: Mon, 3 Jul 2023 17:08:53 +0200
Subject: [PATCH] remove deprecated diversion dating back to squeeze

Closes: #
---
 debian/debian-edu-artwork.postinst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 debian/debian-edu-artwork.postinst

diff --git a/debian/debian-edu-artwork.postinst b/debian/debian-edu-artwork.postinst
new file mode 100644
index 0000000..1e3e7bc
--- /dev/null
+++ b/debian/debian-edu-artwork.postinst
@@ -0,0 +1,12 @@
+#!/bin/sh
+set -e
+
+# can be removed after the release of trixie
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" lt-nl "2.12.2-3~"
+then
+	# remove deprecated diversion dating back to squeeze
+	dpkg-divert --package debian-edu-artwork \
+	            --rename --remove /usr/share/desktop-base/grub_background.sh
+fi
+
+#DEBHELPER#
-- 
2.20.1

Attachment: debian-edu-artwork.log.gz
Description: application/gzip


Reply to: