Re: debian-edu-config_2.12.16_source.changes ACCEPTED into unstable

[Mike Gabriel <sunweaver@debian.org>]

Hi Holger,

On  So 13 Feb 2022 13:46:27 CET, Holger Levsen wrote:

> hi Mike,
>
> I've just done an upload of debian-edu-config 2.12.17 and noticed your
> 2.12.16 upload did have unwanted changes. Could you please check this
> didn't happen to your other uploads, esp those to stable and oldstable?
>
> debian-edu-config (2.12.17) unstable; urgency=medium
>
>   [ Mike Gabriel ]
>   * share/debian-edu-config/tools/clean-up-host-keytabs:
>     - Don't fail on Kerberos principal removal.
>     - Set executable bits of this file.
>   * debian/control:
>     + Add D (debian-edu-config): libsitesummary-perl (available starting with
>       sitesummary 0.1.50). (Closes: #815695, #968268).
>
>  -- Holger Levsen <holger@debian.org>  Sun, 13 Feb 2022 09:45:45 +0100
>
> $ debdiff debian-edu-config_2.12.16.dsc  
> debian-edu-config_2.12.17.dsc|diffstat
>  debian/NEWS                                             |    4 ++--
>  debian/changelog                                        |   14  
> +++++++++++++-
>  debian/control                                          |    1 +
>  etc/apache2/mods-available/debian-edu-userdir.conf.mine |   33  
> ---------------------------------
>  share/debian-edu-config/tools/clean-up-host-keytabs     |    4 ++--
>  share/debian-edu-config/tools/list-gosa-systems         |   42  
> ------------------------------------------
>  6 files changed, 18 insertions(+), 80 deletions(-)
>
> looking closer,
> debian-edu-config-2.12.16/etc/apache2/mods-available/debian-edu-userdir.conf.mine
> contained unresolved git conflicts, and
> debian-edu-config-2.12.16/share/debian-edu-config/tools/list-gosa-systems
> contained the line "# FIXME: MAKE THIS MORE GENERIC BEFORE PUSHING!!!!"
> (and the typo fixes to debian/NEWS were not mentioned, though that doesn't
> really matter.)
>
> Also, I'm not really bothered by these mistakes. If, I'd rather be bothered
> by tools and workflows not catching them. :) (eg it would be nice to  
> be notified
> about uploads not matching given git tags...)

thanks for the second pair of eyes. I noticed both mistakes (those  
extra files) post-upload.

For one of the sec:uploads I had Moritz reject the upload and I  
re-uploaded without the extra list-gosa-systems script.

Mike
--

mike gabriel aka sunweaver (Debian Developer)
mobile: +49 (1520) 1976 148
landline: +49 (4351) 486 14 27

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunweaver@debian.org, http://sunweavers.net

Attachment: pgpgb8G8y8STd.pgp
Description: Digitale PGP-Signatur