[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#969935: debian-edu-ltsp: unused variables, $securitymirror needs /updates -> -security



Package: debian-edu-config
Version: 2.11.30
Severity: minor
File: /usr/sbin/debian-edu-ltsp
User: debian-devel@lists.debian.org
Usertags: bullseye-security
X-Debbugs-CC: team+ltsp@tracker.debian.org, Vagrant Cascadian <vagrant@debian.org>, Alkis Georgopoulos <alkisg@gmail.com>

[CCing the LTSP maintainers for their advice on ltsp-build-client]

The debian-edu-ltsp script contains a $securitymirror variable that is
hard coded to use $dist/updates but with the bullseye suite and later
it should be $dist-security instead. OTOH the $securitymirror variable
appears to be unused so perhaps it and the other unused variables
should either be removed or passed to the ltsp-build-client script at
the end of the debian-edu-ltsp script. As ltsp-build-client doesn't
appear to exist in any package in Debian, perhaps the debian-edu-ltsp
script should just be dropped instead?

   $ shellcheck /usr/sbin/debian-edu-ltsp
   ...
   In sbin/debian-edu-ltsp line 60:
     extramirror=""
     ^---------^ SC2034: extramirror appears unused. Verify use (or export if used externally).


   In sbin/debian-edu-ltsp line 61:
     securitymirror="http://security.debian.org/ $dist/updates main"
     ^------------^ SC2034: securitymirror appears unused. Verify use (or export if used externally).


   In sbin/debian-edu-ltsp line 62:
     components="main"
     ^--------^ SC2034: components appears unused. Verify use (or export if used externally).
   ...

   $ tail -n38 /usr/sbin/sbin/debian-edu-ltsp
   # Check if server uses install or cd to install
   if apt-cache policy ltsp-client | grep -q "cdrom://" ; then
     mirror=file:///media/cdrom
     components="main"
     securitymirror=""
     extramirror=""
   else
     mirror=http://deb.debian.org/debian
  extramirror=""
  securitymirror="http://security.debian.org/ $dist/updates main"
  components="main"
fi

umounts=
exit_handler() {
    # Unmount if anything is mounted
    for dir in $umounts ; do
	info "Unmounting $dir"
	umount $dir || true
    done
}
trap exit_handler EXIT INT

# Mount the CD ROM if needed
case $mirror in
    file:///cdrom)
        mount /cdrom
	umounts="/cdrom"
	;;
    file:///media/cdrom)
        mount /media/cdrom
	umounts="/media/cdrom"
	;;
    *)
        ;;
esac

ltsp-build-client --eatmydata --accept-unsigned-packages --base $base --arch $ARCH --dist $dist

$ apt-file search ltsp-build-client
epoptes: /usr/share/ltsp/plugins/ltsp-build-client/common/040-epoptes-certificate

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-3-amd64 (SMP w/4 CPU threads)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), LANGUAGE=en_AU:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages debian-edu-config depends on:
ii  bind9-host                       1:9.16.6-2
pn  cfengine3                        <none>
ii  debconf [debconf-2.0]            1.5.74
ii  debconf-utils                    1.5.74
pn  debian-edu-artwork               <none>
ii  e2fsprogs                        1.45.6-1
pn  education-tasks                  <none>
pn  fping                            <none>
ii  gnutls-bin                       3.6.15-1
ii  isenkram-cli                     0.44
ii  ldap-utils                       2.4.51+dfsg-1
ii  ldapscripts                      2.0.8-1
ii  libconfig-inifiles-perl          3.000003-1
ii  libfilesys-df-perl               0.92-6+b5
pn  libhtml-fromtext-perl            <none>
ii  libio-socket-ssl-perl            2.068-1
pn  libnet-ldap-perl                 <none>
pn  libnet-netmask-perl              <none>
pn  libnss3-tools                    <none>
pn  libpacparser1                    <none>
pn  libpam-python                    <none>
pn  libproxy1-plugin-kconfig         <none>
ii  libproxy1-plugin-networkmanager  0.4.15-13
ii  libproxy1-plugin-webkit          0.4.15-13
ii  libterm-readkey-perl             2.38-1+b1
pn  libtext-unaccent-perl            <none>
pn  lockfile-progs                   <none>
ii  lsb-base                         11.1.0
ii  lsb-release                      11.1.0
ii  mime-support                     3.64
ii  net-tools                        1.60+git20180626.aebd88e-1
pn  ng-utils                         <none>
ii  openssl                          1.1.1g-1
ii  patch                            2.7.6-6
ii  python3                          3.8.2-3
ii  python3-notify2                  0.3-4
ii  ssl-cert                         1.0.39
pn  swaks                            <none>
pn  tftp-hpa | tftp                  <none>
pn  uuid                             <none>
ii  wget                             1.20.3-1+b3

Versions of packages debian-edu-config recommends:
ii  binutils       2.35-2
ii  libnotify-bin  0.7.9-1
ii  lsof           4.93.2+dfsg-1
pn  memtest86+     <none>
pn  resolvconf     <none>
ii  syslinux       3:6.04~git20190206.bf6db5b4+dfsg1-3

debian-edu-config suggests no packages.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: