[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 2 commits: Adjust sbin/debian-edu-pxeinstall



On Wed, Mar 20, 2019 at 11:09:05AM +0000, Holger Levsen wrote:
> On Mon, Mar 18, 2019 at 02:43:43PM +0000, WolfgangSchweer wrote:
> > 02f4c2cf by Wolfgang Schweer at 2019-03-18T14:39:22Z
> [...]
> > Replace code to determine the distribution so that it also works offline.
> 
> refers to the following change, I believe:
> 
> > -[ "$dist" ]       || dist=$(lsb_release -sc)
> > +[ "$dist" ]       || dist=$(cat /etc/debian_version | cut -d'/' -f1)
 
After lots of digging into it I found out that this change is actually a 
bad idea: while debian_version contains text in case of testing or 
unstable, it contains only the version number (like 9.8). I reverted 
this change.

Thanks to Holger for the review.

Wolfgang

Attachment: signature.asc
Description: PGP signature


Reply to: