[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [debian-edu-commits] [Git][debian-edu/debian-edu-config][master] 5 commits: update-chromium-homepage: Don't complain about non-existing config file when…



On Wed, Oct 24, 2018 at 07:49:37PM +0000, Mike Gabriel wrote:
> =====================================
> share/debian-edu-config/tools/update-chromium-homepage
> =====================================
> @@ -6,6 +6,7 @@
>  set -e
>
>  etcfile=/etc/chromium/policies/managed/debian-edu-homepage-ldap.json
> +mkdir -p $(dirname $etcfile)

IMO rather etc/chromium/policies/managed/ should be added to 
debian/dirs; it seems that this has been forgotten at the time 
'chromium-networked-prefs' had been added (commit 4587452309).
  
> =====================================
> share/debian-edu-config/tools/update-firefox-homepage
> =====================================
> @@ -6,6 +6,7 @@
>  set -e
>  
>  etcfile=/etc/firefox-esr/debian-edu-homepage-ldap.js
> +mkdir -p $(dirname $etcfile)

debian/dirs contains 'etc/firefox-esr', so this additional line seems to 
be unneeded.

Please check.

Wolfgang

Attachment: signature.asc
Description: PGP signature


Reply to: