Hi, On 15-03-18 17:06, Holger Levsen wrote: > On Thu, Mar 15, 2018 at 03:44:02PM +0100, Paul Gevers wrote: >> I believe the attached patch would be able to fix this bug and on top of >> that make the test script a lot simpler and easier to understand. Please >> verify that the script still does what is intended. > > awesome, thanks a lot! (did you test it manually?) I did partially. My computer stalled in the middle (not due to the testing I believe, but due to what I fear is an Emacs bug). Mind you, I believe the test-metapkgs actual fails. Generating logs as I write this message, will send them when they are ready. >> Also, I wonder if really all the current combinations of DESKTOP and >> PROFILE need to be tested, or some smarter combination could be chosen >> such that test time can be reduced while still having confidence that >> most code paths are tested. > > I think the latter would be sufficient indeed. > >> I haven't optimized for this yet. > > I'd certainly welcome another patch based on this one ;) I'd rather have that people knowledgeable on how debian-edu code actually works choose the right set. Paul
Attachment:
signature.asc
Description: OpenPGP digital signature