Hi Wolfgang, On Di 20 Nov 2018 22:08:44 CET, Wolfgang Schweer wrote:
On Tue, Nov 20, 2018 at 02:33:53PM +0000, Mike Gabriel wrote:I am not sure, if the patch is not a functional overkill.Hi Mike, I don't think that this is the case:My observation was, that the x2goagent processes got killed by killer.Yes, but if the user's x2goagent process gets killed, all other processes belonging to this user will be killed as well because the user session isn't registered.
No. The other processes get killed because most of them are X clients to x2goagent (which is a nested Xserver). Once x2goagent is gone, the attached X clients evaporate.
OTOH stale x2goagent processes may still exist from sessions that have been messed up by the user. At least this has been the case when I used NX technology at school to let people connect from home. (Years ago, though, things might be different nowadays.)
Yeah, I know. This should be cleanly handled by the x2gocleansessions script running in the background on all X2Go Servers (launched by x2goserver.service).
It should not be on us (i.e. killer) to clean up that X2Go specific mess. So, stale x2goagent instances can be ignored here.
So maybe, we should protect those only.IMO stale x2goagent processes should be killed.
-> /usr/sbin/x2gocleansessions, not for us.
That's why the patch searches for users with a x2goruncommand process. If this one exists, user applications are actually running and nothing belonging to these users should be killed.
This is true. If we (speaking with my X2Go upstream hat and Debian Edu hat on) want time-limited X2Go sessions, than this bit of code should really go into X2Go Server. I agree on the above.
For the session applications, I am currently working on a sessreg based utmp/wtmp patch against X2Go Server.That sounds very good. Patching the killer script would be obsolete in that case.
I have chewed on different approaches yesterday (and was not too happy). This morning I came up with a solution that I need to propose to the X2Go upstream team (once the patch works 100%).
I am quite positive and assume that we will get this into buster. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
Attachment:
pgpdXsuwmjz9z.pgp
Description: Digitale PGP-Signatur