Re: Bug#719624: Upgrading xrdp

[Andreas Tille <andreas@an3as.eu>]

Hi Dominik,

thanks for working on xrdp and commiting to the repository.

On Mon, Apr 18, 2016 at 09:34:35PM +0200, Dominik George wrote:
>  * It only contains debian/ now.

Do you have any reason for this?
 
>  * get-orig-source fetches sources from GitHub, depending on package
>    version and two variables inrules to determine the versions of
>    librfxcodec and xorgxrdp. I decided to create a single
>    source tarball out of the three since it needs to be manually
>    crafted anyway.
>    I am thinking about cloning the git repo instead and extracting
>    the relevant commit, including submodules, from there.
>    Do you think this would be better?

I'm missing the background knowledge to decide this so I'll leave this
to you.  I have no idea about the motivation to pick a specific commit
and not any other - it would be soooo helpful if upstream would tag
releases.

Please commit your created orig.tar.gz as pristine-tar via

     gbp import-orig --pristine-tar PATH_TO_TARBALL

This is necessary to enable us to work on the very same tarball.  If I
recreate via get-orig-source I will have a different MD5 sum of the
tarball (feel free to seek on debian-devel list for related
discussions).

>  * The packages builds with the proposed workflow.
> 
>  * Most of Mike's and Andreas' remarks were incorporated.
> 
> Maybe you could cast another glance at the package now?

I'll do once pristine-tar and source are available.

Thanks again for your work

       Andreas.

-- 
http://fam-tille.de