[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch for fsautoresize



[Giorgio Pioda]
> Here the patch
>
> ##########################
> --- debian-edu-fsautoresize_orig	2015-09-16 11:50:04.207564573 +0200
> +++ debian-edu-fsautoresize_mod	2015-09-16 11:47:38.885386307 +0200
> @@ -189,11 +189,12 @@
>  sub supported_mountpoints {
>      my %mountpoints;
>      my %devices;
> -    open(M, "/proc/mounts") || die "Unable to open /proc/mounts";
> +    open(M, "/etc/fstab") || die "Unable to open /etc/fstab";

This change the program from operating on the list of currently mounted
mount points, to the list of declared mount points.  I doubt it is a
good idea, as the program should check the currently mounted moint
points.

Why do you believe this patch is the correct approach?  Did the format
of /proc/mounts change?
-- 
Happy hacking
Petter Reinholdtsen


Reply to: