[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#604247: unblock: sitesummary/0.0.67



Hi Petter, Ronny,

On Sonntag, 21. November 2010, Adam D. Barratt wrote:
> On Sun, 2010-11-21 at 14:39 +0100, Holger Levsen wrote:
> > please unblock sitesummary 0.0.67, which includes two trivial bugfixes,
> > one of them set to serious severity.
> >
> > sitesummary (0.0.67) unstable; urgency=low
> >    [ Ronny Aasen ]
> >    * Only run lsscsi from collect.d/system, if /proc/bus/scsi exsists
> >      to avoid errors on machines without /sys mouted, like chroots
> >      and vservers (Closes: #602286).
>
> s/exsists/exists/
>
> Should that not be /sys/bus/scsi, rather than /proc/bus/scsi?  afaics
> there's no connection between the existence of /proc/bus/scsi and /sys
> being mounted.  (and at least on this machine, /proc/bus/scsi doesn't
> exist, /sys/bus/scsi does and lsscsi works fine).
>
> >    [ Petter Reinholdtsen ]
> >    * Change sitesummary-upload to not try to parse an empty
> >      $http_proxy variable.  This get it working on hosts without
> >      a proxy setting (Closes: #604025).
>
> [...]
>
> > -if (defined($http_proxy))
> > +if (defined($http_proxy) && $http_proxy)
>
> That should really be "&& length($http_proxy))", but as an http_proxy
> containing "0" will be rejected as invalid in any case, meh. :)

Please comment to the bug report. Thanks!


cheers,
	Holger

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: