[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#604025: marked as done (sitesummary-upload: Fail when $http_proxy exist and is empty)

Your message dated Fri, 19 Nov 2010 14:50:25 +0000
with message-id <E1PJSID-0006GM-JE@franck.debian.org>
and subject line Bug#604025: fixed in sitesummary 0.0.67
has caused the Debian Bug report #604025,
regarding sitesummary-upload: Fail when $http_proxy exist and is empty
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

604025: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=604025
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sitesummary-client
Version: 0.0.66
Severity: serious
Tags: patch pending

I ran into this when I installed a minimal Debian Edu/squeeze profile
on a new virtual machine.  The host did not get any proxy setting, and
ended up with http_proxy= in /etc/environment.  This caused
sitesummary-client to fail.

The problem can be reproduced like this:
  root@gnashbuild0:~# env|grep http
  root@gnashbuild0:~# echo | http_proxy= sitesummary-upload
  unrecognized http_proxy at /usr/sbin/sitesummary-upload line 36.
  root@gnashbuild0:~# echo | sitesummary-upload
  cannot connect to localhost:80 at /usr/sbin/sitesummary-upload line 60.

Note how it fails with "unrecognized http_proxy" when no value is set,
while it do not when the variable is unset.

I've commited this fix to svn, and believe it is important to get it
included in Squeeze.  Not quite sure if it should be considered
release critical for Debian or not, as it only will affect those using
Debian Edu without a proxy on the local network, but I believe it is
release critical for Debian Edu.  Setting severity serious for now.

Modified: trunk/src/sitesummary/sitesummary-upload
--- trunk/src/sitesummary/sitesummary-upload    2010-11-19 12:27:47 UTC (rev 71290)
+++ trunk/src/sitesummary/sitesummary-upload    2010-11-19 13:48:44 UTC (rev 71291)
@@ -31,7 +31,7 @@
 my ($http_proxy,$proxy,$port,$remote);

-if (defined($http_proxy))
+if (defined($http_proxy) && $http_proxy)
   $http_proxy =~ m{http://([^:]*)(?::([0-9]+))?}
         or die ("unrecognized http_proxy");

Happy hacking,
Petter Reinholdtsen

--- End Message ---
--- Begin Message ---
Source: sitesummary
Source-Version: 0.0.67

We believe that the bug you reported is fixed in the latest version of
sitesummary, which is due to be installed in the Debian FTP archive:

  to main/s/sitesummary/sitesummary-client_0.0.67_all.deb
  to main/s/sitesummary/sitesummary_0.0.67.dsc
  to main/s/sitesummary/sitesummary_0.0.67.tar.gz
  to main/s/sitesummary/sitesummary_0.0.67_all.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 604025@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Petter Reinholdtsen <pere@debian.org> (supplier of updated sitesummary package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Fri, 19 Nov 2010 15:02:20 +0100
Source: sitesummary
Binary: sitesummary sitesummary-client
Architecture: source all
Version: 0.0.67
Distribution: unstable
Urgency: low
Maintainer: Debian Edu Developers <debian-edu@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
 sitesummary - Generate site summary of submitting hosts (server part)
 sitesummary-client - Generate site summary of submitting hosts (client part)
Closes: 602286 604025
 sitesummary (0.0.67) unstable; urgency=low
   [ Ronny Aasen ]
   * Only run lsscsi from collect.d/system, if /proc/bus/scsi exsists
     to avoid errors on machines without /sys mouted, like chroots
     and vservers (Closes: #602286).
   [ Petter Reinholdtsen ]
   * Change sitesummary-upload to not try to parse an empty
     $http_proxy variable.  This get it working on hosts without
     a proxy setting (Closes: #604025).
 96a4c09b15c345324b238161b13ed46df94a53a7 1129 sitesummary_0.0.67.dsc
 f10832fe12fd28b516d36ca6c8763a1c97f9c4d1 66590 sitesummary_0.0.67.tar.gz
 76f057b1d22c39a4adc768b0ae38cc9f9d24811b 44372 sitesummary_0.0.67_all.deb
 6556d09c004534e00795f443c5c75f7be91483f7 30704 sitesummary-client_0.0.67_all.deb
 312dd21dffa0495575d1004ad3ddbf3aed0f878be87c040e8c60bf04562bcda7 1129 sitesummary_0.0.67.dsc
 3af91fd89ec78fa5a936d7b16f05fc989c909812aaf742c37469c1a7ae781ee2 66590 sitesummary_0.0.67.tar.gz
 20e4107754d01fe345d1b7e155e0dde2f57e5f54128eec07869d1b85ad1297b0 44372 sitesummary_0.0.67_all.deb
 c7b7f032c7c57dde51b6deba4ea3cb827658b3d7b9626ed4a905dd9b27d25c06 30704 sitesummary-client_0.0.67_all.deb
 8b50ff3df33d4897fed415fc8a8009e4 1129 misc optional sitesummary_0.0.67.dsc
 399cee7f98ed6f4f187a16754013e680 66590 misc optional sitesummary_0.0.67.tar.gz
 e9e558c41464dd65737e58a0577f3d97 44372 misc optional sitesummary_0.0.67_all.deb
 ab5a245f5862e013994ff6ca0791a1b9 30704 misc optional sitesummary-client_0.0.67_all.deb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: