Bug#493338: debian-edu-config: crontest failure
Hello Holger,
On Fri, Aug 22, 2008 at 02:36:29AM +0200, Holger Levsen wrote:
> On Thursday 14 August 2008 11:27, Filippo Giunchedi wrote:
> > I've prepared an NMU for this bug, debdiff attached.
> > I'd like to upload to DELAYED in a few days if that is okay.
>
> Please dont, the patch has several flaws:
Fair enough, thanks for noticing.
>
> - we are in a freeze and the bug is severity normal.
How is this an issue? Uploads to unstable are permitted AFAIK
> - instead of checking for /usr/bin/innetgr availability, it should should also
> check if debian-edu-config is installed, as it might be removed but not
> purged, so the cronjob will still be running...
> - the changelog entry only explains what it does and not why.
Good points, I've fixed these in the attached debdiff (won't upload, though)
filippo
--
Filippo Giunchedi - http://esaurito.net
PGP key: 0x6B79D401
random quote follows:
Recursion is the root of computation since it trades description for time.
-- Alan Perlis
diff -Nru debian-edu-config-1.423/debian/changelog debian-edu-config-1.423+nmu1/debian/changelog
--- debian-edu-config-1.423/debian/changelog 2008-07-26 01:24:37.000000000 +0200
+++ debian-edu-config-1.423+nmu1/debian/changelog 2008-08-23 19:26:07.000000000 +0200
@@ -1,3 +1,11 @@
+debian-edu-config (1.423+nmu1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Check innetgr and debian-edu-fsautoresize in cron.hourly to give no output
+ when they are not present (Closes: #493338)
+
+ -- Filippo Giunchedi <filippo@debian.org> Sat, 23 Aug 2008 19:16:33 +0200
+
debian-edu-config (1.423) unstable; urgency=low
[ Petter Reinholdtsen ]
diff -Nru debian-edu-config-1.423/debian/debian-edu-config.cron.hourly debian-edu-config-1.423+nmu1/debian/debian-edu-config.cron.hourly
--- debian-edu-config-1.423/debian/debian-edu-config.cron.hourly 2008-07-12 13:27:48.000000000 +0200
+++ debian-edu-config-1.423+nmu1/debian/debian-edu-config.cron.hourly 2008-08-23 19:16:31.000000000 +0200
@@ -3,6 +3,9 @@
PATH=/bin:/usr/bin:/sbin:/usr/sbin
export PATH
+[ -x /usr/bin/innetgr ] || exit 0
+[ -x /usr/sbin/debian-edu-fsautoresize ] || exit 0
+
# Automatically extend full LVM volumes if the host is a member of the
# fsautoresize-hosts netgroup.
hostname=$(uname -n)
Reply to: