[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#370343: Worked out a patch in order to make default file preseedable



> Sorry, nack on this patch in its current form.
>
> - The postinst dynamically creates files under /usr/share.  State files
> like this should only ever be created under /var/lib.
This is no problem.. I can change it fast today.

> - Why are you using a home-grown md5sum solution instead of using ucf? 
> For an effective use of ucf, please see the samba-common package in
> testing/unstable.
Okay, I'll do
> - Why does SLAPD_SERVICES need to be edited at all in your environment -
>   what are the settings that you're preseeding, and wouldn't it be
> better to try to identify a sensible default for this file?  I don't
> think the current behavior of this file *is* a sensible default, because
> ldapi:/// is missing; but ldap:/// ldapi:/// should be a sensible
> default IMHO, excluding ldaps:/// because TLS should be sufficient for
> the common case.  You do mention in the bug report that you specifically
> care about enabling ldaps:///, can you explain why this is needed in
> your environment?  What clients do you have that can't use TLS?
> - Likewise, why do you need to override the location of slapd.conf, as
>   opposed to fixing up the standard slapd.conf for your needs?  This
> wasn't even mentioned before now in your bug report.
We need to include some additional schemes for debian-edu which wouldn't 
make sense as default.
In order to have a look on our configuration file please have a look on: 
http://svn.debian.org/wsvn/debian-edu/trunk/src/debian-edu-config/etc/ldap/slapd-debian-edu.conf?op=file&rev=0&sc=0


> - Oh, and making SLAPD_SERVICES a multiselect breaks things for those
> users who want to bind to specific IPs.
Oh okay... this should be easy to solve with another debconf question and 
some sed magic. 

> I'm sympathetic to your desire to have the slapd package usable
> out-of-the-box for your environment, but I think there needs to be a
> clearer rationale for the particular changes you're proposing.
Okay, I'll try to fix these issues.

Greetings
Winnie



-- 
 .''`.   Patrick Winnertz <winnie@debian.org>
:  :' :  GNU/Linux Debian Developer
`. `'`   http://www.der-winnie.de http://people.skolelinux.org/~winnie
  `-  Debian - when you have better things to do than fixing systems
      Spamtrap: winnie@qsc218.credativ.com

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: