[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: 2. version of sysklogd patch



On Mon, Sep 18, 2006 at 09:48:31AM +0200, Patrick Winnertz wrote:
> Hello! 
> 
> Please look over my second try to patch sysklogd to use debconf
> questions. 
> If your found this patches okay, I will contact the maintainer and talk
> to him, if he could integrate this patches into his package. 

i really agreed with otavio's suggestions, which you haven't seemed to
integrate. how did the lintian run on the package look? i suspect it
will complain about the lack of usig po-debconf.

one small bugfix:

> diff -Nru /tmp/aEIq9ONO4x/sysklogd-1.4.1/debian/config /tmp/3OsP4rY3JE/sysklogd-1.4.1/debian/config
> --- /tmp/aEIq9ONO4x/sysklogd-1.4.1/debian/config	1970-01-01 00:00:00.000000000 +0000
> +++ /tmp/3OsP4rY3JE/sysklogd-1.4.1/debian/config	2006-09-18 07:46:06.000000000 +0000
> @@ -0,0 +1,17 @@
> +#!/bin/sh
> +
> +. /usr/share/debconf/confmodule
> +
> +db_input low sysklogd/sysklogd-default-options || true
> +db_go
> +
> +db_get sysklogd/sysklogd-default-options
> +
> +if [ ! -z "$RET" ]; then 
> +	if [ -z `grep "-r" "$RET"` ]; then
> +		db_input low sysklogd/sysklogd-remot-loghost || true
you probably want:
		db_input low sysklogd/sysklogd-remote-loghost || true
> +		db_go
> +	fi
> +fi
> +db_stop
> +

live well,
  vagrant



Reply to: