[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Fix test_command_exec test (t-command)



Hi!

On Sat, 2022-02-12 at 11:16:11 +0100, Sören Tempel wrote:
> On Fri, 2020-08-28 Guillem Jover <guillem@debian.org> wrote:
> > > Sören Tempel <soeren@soeren-tempel.net> wrote:
> > > > Hope this is the right please to sent patches for dpkg. I am currently
> > > > trying to get the dpkg test suite to pass for our Alpine Linux dpkg
> > > > package. While doing so I noticed a mistake in the test_command_exec()
> > > > function from t-command.c, the function doesn't set arg0 correctly. This
> > > > causes the test to fail as our busybox multicall binary (which provides
> > > > /bin/true) is not capable of finding an applet for "arg 0". Other
> > > > invocations of command_exec in dpkg explicitly set arg0 manually too.
> > > > The patch is attached as a git-format-patch(1).
> > 
> > Indeed, thanks for the patch! Will include it in git in my next push.
> 
> I think this was forgotten about? At Alpine we still need to apply my
> proposed in order to get the dpkg test suite to pass. Any chance you
> could apply it upstream? (:

I indeed lost it somewhere. It's now pushed to git main, and will be
included in the upcoming 1.21.2 release. Sorry!

Thanks,
Guillem


Reply to: