[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#879014: gpgme1.0: FTBFS on some arches: Qt needs a compile with -fPIC (PIE is not enough), hardening downgrades to PIE

Control: reopen -1
Control: tag -1 - patch

On Tue, 2020-07-07 at 07:06:34 +0200, Guillem Jover wrote:
> On Wed, 2020-07-01 at 17:20:40 -0400, Daniel Kahn Gillmor wrote:
> > Further conversation about problems compiling and linking against Qt and
> > GPGME in debian suggest that the problem might be related to dpkg's
> > default spec files, and confused by Qt's compiler warnings.
> > 
> > I'm attaching a patch to dpkg which (i think) reflects the fix proposed
> > by Guillem Jover (in cc):
> Yes this is what I had locally, thanks for testing! I'm including a
> fix in the next upload.

> > --- a/data/no-pie-compile.specs
> > +++ b/data/no-pie-compile.specs
> > @@ -1,2 +1,2 @@
> > -*self_spec:
> > ++self_spec:
> >  + %{!r:%{!fpie:%{!fPIE:%{!fpic:%{!fPIC:%{!fno-pic:-fno-PIE}}}}}}

Ok, so Thorsten Glaser very helpfully pointed out that this is actually
bogus, as the + is supposed to go with the text not the spec name (which
was already there!). In this case I assume it gets interpreted as a
«[SUFFIX]:» entry, and then this get completely ignored (w/o an error
diagnostic), disabling all the specs files (confirmed by Thorsten on
x32), that's why the specific problem with gpgme+Qt stopped failing in
Daniel's tests.

I'll revert this in a quick .5 upload later today, and then try to
track down what's going on, and add some unit tests for the specs files,
so that this gets tested on architectures where it truly affects them.


Reply to: