[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [dpkg] 50/130: debian: Use perl:Depends via dh_perl instead of a hardcoded perl



Hi!

On Sun, 2016-10-30 at 22:25:04 +0100, Sven Joachim wrote:
> On 2016-10-30 05:46 +0000, Guillem Jover wrote:
> > diff --git a/debian/rules b/debian/rules
> > index d57fa22..212a5a8 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -138,6 +138,7 @@ binary-indep: install
> >  	dh_installman -i
> >  	dh_link -i
> >  	dh_lintian -i
> > +	dh_perl -i
> >  	dh_strip -i
> >  	dh_compress -i
> >  	dh_fixperms -i
> 
> Should dpkg-dev depend on ${perl:Depends} as well?  While not strictly
> necessary, that seems correct to me and avoids this warning at the end
> of the build:

> ,----
> | dpkg-gencontrol: warning: package dpkg-dev: unused substitution variable ${perl:Depends}
> `----

Yeah, I did this now.

> On the other hand, having dpkg-dev depend on perl:any might break
> "debootstrap --variant=buildd" as long as bug #836525[1] is not
> fixed. :-(

I'd assume that having libdpkg-perl would break it anyway, so I went
ahead, more so given that you had already provided a patch there. :)

Thanks,
Guillem


Reply to: