Re: [dpkg] 50/130: debian: Use perl:Depends via dh_perl instead of a hardcoded perl

[Sven Joachim <svenjoac@gmx.de>]

On 2016-10-30 05:46 +0000, Guillem Jover wrote:

> commit 8de212101893d64d519d2b70d7e8c8d867d3df84
> Author: Guillem Jover <guillem@debian.org>
> Date:   Tue Oct 4 04:19:57 2016 +0200
>
>     debian: Use perl:Depends via dh_perl instead of a hardcoded perl
> ---
>  debian/changelog | 1 +
>  debian/control   | 2 +-
>  debian/rules     | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/debian/changelog b/debian/changelog
> index 16dd246..8df097a 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -7,6 +7,7 @@ dpkg (1.18.11) UNRELEASED; urgency=medium
>      - Remove obsolete dependency relationships, since Debian oldstable.
>      - Remove update-alternatives, dpkg-divert and dpkg-statoverride
>        compatibility symlinks, again.
> +    - Use perl:Depends via dh_perl instead of a hardcoded perl in Depends.
>    * Documentation:
>      - Update custom changelog parser API support status in README.api.
>      - Fix typos in docs and man pages. Thanks to Jakub Wilk <jwilk@debian.org>
> diff --git a/debian/control b/debian/control
> index 11780da..6d28c74 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -121,7 +121,7 @@ Architecture: all
>  Multi-Arch: foreign
>  Depends:
>   ${misc:Depends},
> - perl,
> + ${perl:Depends},
>  Recommends:
>  # Used by Dpkg::File.
>   libfile-fcntllock-perl,
> diff --git a/debian/rules b/debian/rules
> index d57fa22..212a5a8 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -138,6 +138,7 @@ binary-indep: install
>  	dh_installman -i
>  	dh_link -i
>  	dh_lintian -i
> +	dh_perl -i
>  	dh_strip -i
>  	dh_compress -i
>  	dh_fixperms -i

Should dpkg-dev depend on ${perl:Depends} as well?  While not strictly
necessary, that seems correct to me and avoids this warning at the end
of the build:

,----
| dpkg-gencontrol: warning: package dpkg-dev: unused substitution variable ${perl:Depends}
`----

On the other hand, having dpkg-dev depend on perl:any might break
"debootstrap --variant=buildd" as long as bug #836525[1] is not
fixed. :-(

Cheers,
       Sven


1. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836525