Re: dpkg-source unpack failures

[Guillem Jover <guillem@debian.org>]

Hi!

On Mon, 2014-06-30 at 00:04:55 +0200, Jakub Wilk wrote:
> [I'm not subscribed, please CC me on replies.]

[ Please, fix your Mail-Followup-To then, it's currently being set to
  only the list. :) ]

> FYI, according to the recent archive-wide test rebuild, a few packages
> failed to unpack:
> 
> #753194: flite: FTBFS: dpkg-source: error: expected ^--- in line 10 of diff `flite-1.4-release/debian/patches/CVE-2014-0027_unsafe_temporary_file.patch'
> #753184: foremost: FTBFS: dpkg-source: error: expected ^--- in line 3 of diff `foremost-1.5.7/debian/patches/fix-lintian-hardening-warnings.patch'
> #753178: hfsutils: FTBFS: dpkg-source: error: expected ^--- in line 1 of diff `hfsutils-3.2.6/debian/patches/man-macros.diff'
> #753219: katoob: FTBFS: dpkg-source: error: expected ^--- in line 2 of diff `katoob-0.5.9.1/debian/patches/replace_fribidi-config_pkg-config.patch'
> #753175: kvpm: FTBFS: dpkg-source: error: expected ^--- in line 4 of diff `kvpm-0.8.6/debian/patches/bug-667232.patch'
> #753235: lldpad: FTBFS: dpkg-source: error: expected ^--- in line 2 of diff `lldpad-0.9.46/debian/patches/fix-typo-in-lldptool-ets-8.patch'
> #753229: lurker: FTBFS: dpkg-source: error: expected ^--- in line 23 of diff `lurker-2.3/debian/patches/02_nested_frontends.patch'
> #753226: lutefisk: FTBFS: dpkg-source: error: expected ^--- in line 3 of diff `lutefisk-1.0.7+dfsg/debian/patches/build-flags'
> #753241: nsnake: FTBFS: dpkg-source: error: expected ^--- in line 4 of diff `nsnake-1.5/debian/patches/hardening.patch'
> 
> This seems to be fallout from the recent fixes for directory traversals.

Thanks, for the notice, I've checked them all, and most seem just
botched patches, but still this is annoying. :/

- Newline missing between comment header and --- header:

  foremost
  katoob
  kvpm
  lldpad
  lutefisk
  nsnake

- Bogus hunk marker in the Debian patch, original is fine:

  flite

- Patch hunk w/o --- nor +++ header line, so the filename is unknown and
  it cannot be applied:

  hfsutils

- Patch hunk w/o a --- header line (this is the only one that could be
  considered semi-ok):

  lurker

David, would it be possible to do a simple dpkg-source unpack run over
the stable archive, with the security update (dpkg 1.16.15), to check
if there's any regressions there?

Thanks,
Guillem