[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Broken dpkg-dev in git



On Fri, 19 Apr 2013, Guillem Jover wrote:
> The following commit has been merged in the master branch:
> commit 26a4d1df1119da0a8601b27198086086f9f3249f
> Author: Guillem Jover <guillem@debian.org>
> Date:   Sat Dec 29 23:59:06 2012 +0100
> 
>     Use just 'return' instead of 'return undef' in perl code
>     
>     This makes sure the functions always return the appropriate value
>     independent of the context.
>     
>     Fixes Subroutines::ProhibitExplicitReturnUndef.
>     
>     Warned-by: perlcritic

This commit broke code (I have at least some missing Architecture fields in
.dsc or .changes). It's a semantic change when a function used to return (undef)
in list context and now returns the empty list () instead...

I have pushed some fixes for warnings that I saw, like the one below, but there
might be more remaining.

dpkg-buildpackage: source changé par Raphaël Hertzog <hertzog@debian.org>
 dpkg-source -i -I --before-build kali-menu-1.338
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.
Use of uninitialized value in string eq at /usr/share/perl5/Dpkg/Arch.pm line 404.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/


Reply to: