[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[patch] always send the full name on the --status-fd


I would like to ask for the inclusion of the attached patch. It simply
makes dpkg always send the full pkgname:arch on the status-fd. This
will help the progress reporting code in apt. There is code in apt now
to deal with this case so its not urgent, but it still would be nice
if the status-fd had the full information for the frontends.

>From 92f86c58f239804a71b1141302255ed6e945fb1d Mon Sep 17 00:00:00 2001
From: Michael Vogt <mvo@debian.org>
Date: Sat, 7 Sep 2013 09:36:55 +0200
Subject: [PATCH] Always send the architecture with the pkgname on the

The status-fd currently get the architecture information for some
packages but not for all packages. So fontends not expecting the
architecture information will break in subtle ways, i.e. progress
does not go from 0-100% as the frontend expects package names
without architecture information and gets some with and some without.

By always sending the architecture information this is consitent.
 lib/dpkg/dbmodify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dpkg/dbmodify.c b/lib/dpkg/dbmodify.c
index 61cfcb3..6dc9f4e 100644
--- a/lib/dpkg/dbmodify.c
+++ b/lib/dpkg/dbmodify.c
@@ -410,7 +410,7 @@ void modstatdb_note(struct pkginfo *pkg) {
   log_message("status %s %s %s", statusinfos[pkg->status].name,
               pkg_name(pkg, pnaw_always),
 	      versiondescribe(&pkg->installed.version, vdew_nonambig));
-  statusfd_send("status: %s: %s", pkg_name(pkg, pnaw_nonambig),
+  statusfd_send("status: %s: %s", pkg_name(pkg, pnaw_always),
   if (cstatus >= msdbrw_write)

Reply to: