Re: [SCM] dpkg's main repository branch, master, updated. 1.16.1.2-341-g65c28bd

[Guillem Jover <guillem@debian.org>]

On Fri, 2012-03-16 at 20:54:35 +0100, Sven Joachim wrote:
> On 2012-03-16 15:07 +0100, Guillem Jover wrote:
> > +	/* Ignore removal request if the diverted file is still owned
> > +	 * by another package in the same set. */
> > +	if (diversion_is_shared(pkgset, namenode)) {
> > +		if (opt_verbose > 0)
> > +			printf(_("Ignoring removal of shared diversion '%s'.\n"),
> > +			       diversion_describe(contest));
> > +		exit(0);
> > +	}
> 
> The message could use some improvement, I think.  As stated in the
> comment, it is the _request_ to remove the diversion which is ignored,
> but the unsuspecting user might be misled to think "the shared diversion
> has been removed, and somehow this fact is ignored".

Would the following clarify?

  "Ignoring removal request of shared diversion '%s'.\n"

If so, I'll be including this in the last push I'm about to do today,
before the upload, after I've ironed out a corner-case I stumbled over.

thanks,
guillem