[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug #583585 dpkg-maintscript-helper



Hi Gianluca,

I stumbled upon your patch trying to accomplish the same thing in my own
package (but I guess I'll just postpone my changes until
dpkg-maintscript-helper can take care of all the details for me) and
have some minor comments on the patch. I can't comment on the actual
working of the patch, though ;-)

> +   local LAST_VERSION="$2"
Shouldn't that one really be called FIRSTVERSION, since it's the first
version that contains the link (as opposed to the last version to not
contain the link)?

> + # In the case statement, $1 is the name of the maint script, $2 the
> + # package version
This comment seems untrue to me, $1 and $2 are the arguments passed to
the maintainer script (action and version, usually)? At least the "name
of the maint script" is $DPKG_MAINTSCRIPT_NAME, right?

> +	error "the package has no exclusive ownership of the directory; "\
> +	      "please check permissions"
This error message is confusing: It suggests that there is a problem
with the filesystem permissions, while you are really checking the
"owning packages" for the directory.

Gr.

Matthijs

Attachment: signature.asc
Description: Digital signature


Reply to: