Re: [PATCH] Add new variables, DEB_HOST_MULTIARCH and DEB_BUILD_MULTIARCH
On Tue, 2011-03-08 at 19:04:16 -0800, Steve Langasek wrote:
> On Wed, Mar 09, 2011 at 03:47:00AM +0100, Guillem Jover wrote:
> > So I guess this would need either the corresponding fixup in
> > debian/rules,
>
> Ah, yes; hadn't realized that this was being done via debian/rules, I guess
> it would have had to be since dpkg was otherwise in sync between Debian and
> Ubuntu. I can add this.
My hope is to be able to eventually remove that code in the future
somehow. :)
> > or maybe better to use a regex for the GNU triplet, although then the
> > bi-direction mapping becomes a bit more cumbersome, but I don't think we
> > need it right now anyway?
>
> ... or I can drop the bi-directional mapping, too, whichever you prefer. I
> agree that there's no strong need for it, I was just following the model of
> the existing code.
>
> I don't think it's worth doing this with regex, though; I would just add
> multiple entries to the table.
Well it's probably more future proof, but I don't think I really mind
either way (regex or explicit list).
> BTW, I've just noticed that the !linux i386 architectures also need to be
> added to this table; sorry about that. I can clean that up at the same time
> as fixing the above issue, however you recommend it be fixed.
Oh right! How annoying. :)
Hmm, or maybe given that the only current exception is i386, we are just
better off handling it directly in the function, we can always move to
a table or whatever if there happens to be more special casing in the
future (which I doubt?).
thanks,
guillem
Reply to: