[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH/RFC] dpkg-source: add option to provide arbitrary commands for --before-build

Raphael Hertzog wrote:

> In your use cases, the commands are clearly used
> to create or modify content of the upstream source packake which means
> that the net result is that your source package will end up with a 
> new debian-changes-<ver> patch that would be misleading if it contained
> the last changelog entry as justification of the patch.

Good point.  The hook should run after all other patches have been
applied, and the man page should encourage use of debian/source/patch-header
to explain the resulting patches.

> You could do something more elaborate in that hook like using quilt to
> record those changes in a new patch but then it starts to look like
> overkill for the intended goal.

No need, I think, since dpkg-source would automatically rebuild
debian/patches/debian-changes to incorporate the result.

> I also would like to see support from more than one developer for such a
> feature before I accept to merge something like this.

Sure, I would also like to get more feedback before commiting to
supporting something like this.

Thanks for the comments.

Reply to: