[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Dpkg::Deps: fix "Use of uninitialized value" warnings from dpkg-shlibdeps



Hi,

On Sun, 07 Mar 2010, Jonathan Nieder wrote:
> Since commit 113533 (Dpkg::Deps: cleanup API, 2009-12-02), the REL_*
> Unfortunately, the => operator stringizes the REL_* identifiers, so
> that their names rather than their values get used as keys.  As a
> result, expressions like %relation_ordering{'>='} are no longer
> defined.

Good catch, I fixed it by using the function notation CONSTANT() instead,
I find it clearer and it's consistent with other code in libdpkg-perl
(see %FIELD_ORDER in Dpkg::Control::Fields).

Thanks for the report and the patch anyway!

BTW, I'm glad to see some people using the git version of dpkg, I would
like more people like you, we really more testers for our changes before
we upload.

Cheers,
-- 
Raphaël Hertzog

Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/


Reply to: