[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code



Hi!

On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote:
> If only C had templates!  Without function templates, macros
> like these two will have to do.
> 
> This patch refactors the callers for zlib and libbz2 library
> functions to share some code, in preparation for some small
> changes that apply to both.

This one I didn't apply, as the code just seems similar, but it would
make it more difficult to handle once the need to diverge. Also given
the signal handling brokeness and possible refactoring and combination
with the buffer API I might want to rewrite those w/o using the
compression library IO interfaces.

thanks,
guillem


Reply to: