[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Use FIBMAP to sort .list files before scanning



> FIBMAP has one problem: it's potentially unsafe and it's guarded with
> CAP_SYS_RAWIO.

Are you sure that it's unsafe when it's always called on offset 0, on
files that are almost certainly flushed to disk (dpkg calls fsync
after creating them)?

> FIEMAP doesn't require CAP_SYS_RAWIO, so it *should*
> be safe, but the lack of the capapability check might be an oversight.

FIEMAP was not even available in unstable when I wrote the patch.


Reply to: