[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Fix build when po4a is not available



Hi!

On Sun, 2009-10-25 at 15:40:16 +0200, Felipe Contreras wrote:
> diff --git a/Makefile.am b/Makefile.am
> index 8fe8726..aaa7d85 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -4,6 +4,10 @@ if WITH_DSELECT
>    MAYBE_DSELECT = dselect
>  endif
>  
> +if WITH_PO4A
> +  MAYBE_MAN = man
> +endif
> +
>  SUBDIRS = \
>  	lib \
>  	dpkg-deb \
> @@ -13,7 +17,7 @@ SUBDIRS = \
>  	$(MAYBE_DSELECT) \
>  	scripts \
>  	po \
> -	man
> +	$(MAYBE_MAN)
>  
>  ACLOCAL_AMFLAGS = -I m4
>  
> diff --git a/configure.ac b/configure.ac
> index 52f019c..67bba57 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -59,6 +59,9 @@ AC_PROG_LEX
>  AC_PROG_RANLIB
>  DPKG_PROG_PERL
>  
> +AC_CHECK_PROG([PO4A], [po4a])
> +AM_CONDITIONAL([WITH_PO4A], [test -n "$PO4A"])
> +
>  # Checks for operating system services and capabilities.
>  AC_SYS_LARGEFILE

The problem with this patch is that it disables man pages completely
when there's no po4a, it also does not honour the NLS setting. I've
pushed this instead:

  <http://git.debian.org/?p=dpkg/dpkg.git;a=commit;h=679d1d75>

Thanks!

regards,
guillem


Reply to: