[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] move quote_filename into help.c, and remove static scope, as it will also


On Wed, 2009-09-23 at 11:53:16 +0200, sean finney wrote:
> On Sat, Sep 19, 2009 at 05:00:15PM +0200, Guillem Jover wrote:
> > > -quote_filename(char *buf, int size, char *s)
> > > +char* quote_filename(char *buf, int size, char *s)
> > Could you move this to lib/dpkg/path.[ch] instead, with the proper
> > prefix rename, etc?
> sure thing.  fyi the remainder of the changes don't rebase cleanly
> against the latest HEAD--it seems they overlap in a couple places with
> the triggers commits, and there's some other activity causing rebase/merge
> conflicts (moving lib/dpkg.h -> lib/dpkg/dpkg.h, at least).  i'll take a
> look at updating that.
> while i'm at it i'll also squash away the original path-based version
> of the database, since i think with a dpkg-conffile utility it's better
> to use the md5sums-based version instead (i think that was the general
> consensus anyway).  if it makes sense i'll also squish/resplit the commits
> into more logical changesets for review.

I skimmed over the patches the other day and they look sane, so yes,
if you could do the rebase and split, that would be great. Once you
have the new patches we can go over them in more detail.


Reply to: