[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Add --foreign-architecture and --print-foreign-architectures options

On Sat, Aug 29, 2009 at 03:48:36AM +0200, Guillem Jover wrote:
> >  void cmpversions(const char *const *argv) {
> >    struct relationinfo {
> >      const char *string;
> > diff --git a/src/main.c b/src/main.c
> > index d237054..b2cce63 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -152,6 +152,7 @@ usage(void)
> >  
> >  const char thisname[]= "dpkg";
> >  const char architecture[]= ARCHITECTURE;
> > +struct architecture *foreign_archs = NULL;

> Better foreign_arches, well sounds that way to me, but then I'm not a
> native speaker. :)

I see that this has been used consistently throughout the code to date
(albeit not the C code), but this is definitely wrong to me as a native
speaker. :/  The pluralization rules in English are that you add "es"
instead of "s" to words that end in the *sound* /ch/ (IPA: ʧ), but the word
"arch" is an abbreviation of "architecture", so is pronounced "ark" (IPA:
ɑrk), and the pluralization rule is to just add "s".

Cf. "patriarch, patriarchs".

So this is one style change that I'm not going to make. :)

The rest are included in the attached revised patch.

> And do not call it yet, I'd like to add that part only later on once
> it's safe to install foreign architecture packages. Or rather, split it
> into another patch that
> we'll keep at the end of the branch.

Right, done - also attached as a separate patch.

> And thinking about it maybe add a warning on --foreign-architecture
> stating it's currently a no-op.

Opted not to do this at the moment, focusing on making it a non-no-op soon

Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

<<< multipart/mixed; boundary="------------": Unrecognized >>>

<<< multipart/mixed; boundary="------------": Unrecognized >>>

Attachment: signature.asc
Description: Digital signature

Reply to: