[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#474949: debsign: deals badly with Format: 1.8 .changes files and new Checksums-* headers



On Tue, 08 Apr 2008, Adam D. Barratt wrote:
> I've already committed a patch to SVN which does similar; a copy is 
> attached in case anyone can spot any obvious mistakes.

Seems to work fine here. I'd suggest using case-insensitive matching (//i)
for /^Files: / and /^Checksums-(Sha1|Sha256): /. The field name are case
insensitive in theory.

The usage of a temporary file is a nice improvement compared to my patch.
The duplication of code for each checksum is a slight regression however.
;-) (not a big deal though)

A+
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/


Reply to: