Re: Making Source-Version binNMU-safe
On Tue, Nov 01, 2005 at 07:16:33PM -0500, Nathanael Nerode wrote:
> --- controllib.pl.old 2005-11-01 18:30:24.000000000 -0500
> +++ controllib.pl 2005-11-01 18:59:59.000000000 -0500
> @@ -241,6 +241,10 @@
> &parsecdata('L',0,"parsed version of changelog");
> close(CDATA); $? && &subprocerr("parse changelog");
> $substvar{'Source-Version'}= $fi{"L Version"};
> + # Strip off any binNMU version suffix.
> + $substvar{'Source-Version'} =~ s/(-[\d+]+\.[\d+]+)\.[\d+]+$/$1/;
That is actually buggy. In case the Debian version is
"-1.0.1" your code would produce "-1.0", but the correct result would be
"-1".
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: