Bug#246906: misplaced patch

[browaeys.alban@wanadoo.fr]

I wondered if it was a good idea to add more misleading report to this
bug.
I sent the patch to this one by error. I resent it to 273407 afterwards
and also asked if there is a way to remove those mailed that ended on
246906 by error.

You are right , from the perldoc perlvar
if (open(FH, $filename)) {
	# Here $! is meaningless.
	...
} else {
	# ONLY here is $! meaningful.
	...
	# Already here $! might be meaningless.
}

so i would agreee with you that $! can be used to retrieve the error ,
also in all case pointed in this patch we are after an "if" , thus in
the meaningless zone.

Hope you can help. Afaik i did not found the fix in perldoc. I don"t
know why but | are not found in those (the symbol is bigger, is it
really a pipe ?).
I read code from cpan and google groups and found they use $| in the
same case where our code failed.


As you see i would like to be a perl mong, but i am not. I just read
code, docs and test patches before sending them. And the one i sent
ensure a proper behaviour, test it . If you know better please fix my
patch, don"t just tell me i am wrong.


Regards
Alban