Bug#133640: some issues still left

[Michael Banck <mbanck@debian.org>]

Hi,

I've just built a dpkg from a tarball provided by Scott.

There are two-and-a-half issues:

1. We really need to pass -std=gnu99, otherwise this error appears:

start-stop-daemon.c:775: error: 'for' loop intial declaration used
	outside C99 mode

--- ../cvs/dpkg-1.10.21/utils/Makefile.in
+++ dpkg-1.10.21.ogi.2/utils/Makefile.in
@@ -71,6 +71,9 @@ endif
        $(mkinstalldirs) $(DESTDIR)/$(man1dir)
        $(INSTALL_DATA) $(srcdir)/$(MD5_MANPAGES) $(DESTDIR)/$(man1dir)

+# When compiled for the Hurd, start-stop-daemon.c should be compiled
+# with C99 features enabled.
+start-stop-daemon.o: CFLAGS += -std=gnu99
 start-stop-daemon: $(SSD_OBJECTS) ../lib/libdpkg.a
        $(CC) $(LDFLAGS) -o $@ $(SSD_OBJECTS) $(LIBS) $(SSD_LIBS)

2. One part of Neal's patch did not get applied yet, and I still get
segfaults without it (and it's fine after applying it): 

(utils/start-stop-daemon.c)
@@ -722,6 +724,14 @@ check_all (void *ptr)

 static void
 do_procinit(void)
+{
+        /* Nothing to do. */
+}
+
+static void do_libpsinit(void)  __attribute__ ((constructor));
+
+static void
+do_libpsinit(void)
 {
        struct ps_context *context;
        error_t err;
                                                                                   
2.5: There's an unrelated parse error in utils/md5sum.c.

Sorry if the diffs don't apply cleanly, I copy&pasted them from the BTS
web pages.

cheers,

Michael

-- 
Michael Banck
Debian Developer
mbanck@debian.org
http://www.advogato.org/person/mbanck/diary.html