[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#163061: dpkg-buildpackage has poor heuristics to decide between pgp and gpg



tags 163061 + patch
thanks

Here's the one-line patch I am applying to debsign, translated to a
patch for dpkg-buildpackage.  It fixes bugs #158614 and #211031 in
devscripts, and so would fix the same issues in dpkg-buildpackage.

--- /usr/bin/dpkg-buildpackage	2003-10-25 21:51:27.000000000 +0100
+++ dpkg-buildpackage	2003-10-28 11:34:27.000000000 +0000
@@ -48,7 +48,7 @@
 
 rootcommand=''
 signcommand=""
-if [ -e $GNUPGHOME/secring.gpg -o -e $HOME/.gnupg/secring.gpg ] && \
+if [ \( -n "$GNUPGHOME" -a -e "$GNUPGHOME" \) -o -e $HOME/.gnupg ] && \
 		command -v gpg > /dev/null 2>&1; then
 	signcommand=gpg
 elif command -v pgp > /dev/null 2>&1 ; then

It handles the cases:
(1) the GNUPG secret keyring is in a location specified in the GNUPG
    options file, and not ~/.gnupg/secring.gpg
(2) the GNUPG directory has been chmod 000 for a small amount of extra
    security; the effect is to get a more meaningful error message

   Julian

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

        Julian Gilbey, website: http://www.polya.uklinux.net/
   Debian GNU/Linux Developer, see: http://people.debian.org/~jdg/
     Visit http://www.thehungersite.com/ to help feed the hungry



Reply to: