Bug#159381: dselect: memory leaks (valgrind does its job ;)

[Adam Heath <adam@doogie.org>]

On Tue, 3 Sep 2002, Bastian Kleineidam wrote:

> Now thats a quick reply!
>
> On Mon, Sep 02, 2002 at 06:45:06PM -0500, Adam Heath wrote:
> > On Tue, 3 Sep 2002, Bastian Kleineidam wrote:
> > > I am trying the "update, select, exit" procedure now, but it is very slow,
> > > eating a lot of memory.
> > > Filing this bug for now.
> >
> > it'll take 1.1 gigs of memory.
> Yeah, nothing like a good swap partition :)
>
> Well, just for completeness:
> ==31350== 114 bytes in 5 blocks are definitely lost in loss record 16 of 32
> ==31350==    at 0x400434EB: malloc (vg_clientfuncs.c:100)
> ==31350==    by 0x8057D5E: m_malloc (/home/calvin/src/dpkg-1.10.5/lib/mlib.c:50)
> ==31350==    by 0x80570CC: writedb (/home/calvin/src/dpkg-1.10.5/lib/dump.c:280)
> ==31350==    by 0x8056178: checkpoint (/home/calvin/src/dpkg-1.10.5/lib/dbmodify.c:196)
> ==31350==
>
> Seems that oldfn and newfn in dump.c::writedb are not freed.

Already have that fixed, just didn't want the code that fixed it in 1.10.5.
It'll be part of 1.11, which contains more sweeping memory fixes.

I've reduced the memory usage of dpkg-query -S foo by 48%(this is the file
database, which is a large part of the memory needed for dpkg -i).